[Safe Browsing] Only check main frame and iframe URLs on Mobile, for speed.

chrome/browser/safe_browsing/remote_database_manager.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/safe_browsing/remote_database_manager.h"
 
 #include <vector>
 
 #include "base/metrics/histogram_macros.h"
+#include "base/strings/string_number_conversions.h"
+#include "base/strings/string_split.h"
 #include "base/timer/elapsed_timer.h"
 #include "chrome/browser/safe_browsing/safe_browsing_api_handler.h"
+#include "components/variations/variations_associated_data.h"
 #include "content/public/browser/browser_thread.h"
 
 using content::BrowserThread;
 
+namespace {
+
+// Android field trial
+const char kAndroidFieldExperiment[] = "SafeBrowsingAndroid";
+const char kAndroidFieldParam[] = "enabled";
+const char kAndroidFieldParamEnabledValue[] = "true";
+const char kAndroidTypesToCheckParam[] = "types_to_check";
+
+}  // namespace
+
 //
 // RemoteSafeBrowsingDatabaseManager::ClientRequest methods
 //
 class RemoteSafeBrowsingDatabaseManager::ClientRequest {
  public:
   ClientRequest(Client* client,
                 RemoteSafeBrowsingDatabaseManager* db_manager,
                 const GURL& url);
 
   static void OnRequestDoneWeak(const base::WeakPtr<ClientRequest>& req,
@@ skipping 43 matching lines @@
   client_->OnCheckBrowseUrlResult(url_, matched_threat_type, metadata);
   UMA_HISTOGRAM_TIMES("SB2.RemoteCall.Elapsed", timer_.Elapsed());
   // CancelCheck() will delete *this.
   db_manager_->CancelCheck(client_);
 }
 
 //
 // RemoteSafeBrowsingDatabaseManager methods
 //
 
-// TODO(nparker): Add tests for this class
+// TODO(nparker): Add more tests for this class
 RemoteSafeBrowsingDatabaseManager::RemoteSafeBrowsingDatabaseManager()
     : enabled_(false) {
-  DCHECK_CURRENTLY_ON(BrowserThread::UI);
+
+  // Check if the field trial is enabled.
+  const std::string enabled_param = variations::GetVariationParamValue(
+      kAndroidFieldExperiment, kAndroidFieldParam);
+  is_android_field_trial_enabled_ =
+      (enabled_param == kAndroidFieldParamEnabledValue);
+
+  // Decide which resource types to check. These two are the minimum.
+  resource_types_to_check_.insert(content::RESOURCE_TYPE_MAIN_FRAME);
+  resource_types_to_check_.insert(content::RESOURCE_TYPE_SUB_FRAME);
+
+  // The param is expected to be a comma-separated list of ints
+  // corresponding to the enum types.
+  const std::string ints_str = variations::GetVariationParamValue(
+      kAndroidFieldExperiment, kAndroidTypesToCheckParam);
+  for (const std::string& val_str : base::SplitString(
+           ints_str, ",", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL)) {
+    int i;
+    if (base::StringToInt(val_str, &i) && i >= 0 &&
+        i < content::RESOURCE_TYPE_LAST_TYPE) {
+      resource_types_to_check_.insert(static_cast<content::ResourceType>(i));
+    }
+  }
 }
 
 RemoteSafeBrowsingDatabaseManager::~RemoteSafeBrowsingDatabaseManager() {
   DCHECK(!enabled_);
 }
 
 bool RemoteSafeBrowsingDatabaseManager::IsSupported() const {
-  return SafeBrowsingApiHandler::GetInstance() != nullptr;
+  return SafeBrowsingApiHandler::GetInstance() != nullptr &&
+         is_android_field_trial_enabled_;
+}
+
+bool RemoteSafeBrowsingDatabaseManager::ChecksAreAlwaysAsync() const {
+  return true;
+}
+
+bool RemoteSafeBrowsingDatabaseManager::CanCheckResourceType(
+    content::ResourceType resource_type) const {
+  return resource_types_to_check_.count(resource_type) > 0;
 }
 
 bool RemoteSafeBrowsingDatabaseManager::CanCheckUrl(const GURL& url) const {
   return url.SchemeIs(url::kHttpsScheme) || url.SchemeIs(url::kHttpScheme) ||
          url.SchemeIs(url::kFtpScheme);
 }
 
 bool RemoteSafeBrowsingDatabaseManager::download_protection_enabled()
     const {
   return false;
@@ skipping 110 matching lines @@
 
   // Call back and delete any remaining clients. OnRequestDone() modifies
   // |current_requests_|, so we make a copy first.
   std::vector<ClientRequest*> to_callback(current_requests_);
   for (auto req : to_callback) {
     DVLOG(1) << "Stopping: Invoking unfinished req for URL " << req->url();
     req->OnRequestDone(SB_THREAT_TYPE_SAFE, std::string());
   }
   enabled_ = false;
 }
-