Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 1410853002: [Interpreter] Add support for RegExp literals. (Closed)

Created:
5 years, 2 months ago by rmcilroy
Modified:
5 years, 2 months ago
Reviewers:
Benedikt Meurer, oth
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Add support for RegExp literals. Adds support for creating RegExp literals and adds some tests. Adds the CreateRegExpLiteral bytecode. BUG=v8:4280 LOG=N TBR=bmeurer@chromium.org Committed: https://crrev.com/a1e9a6d77fcd3dec7245fef9aba45341eff0d26d Cr-Commit-Position: refs/heads/master@{#31345}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+166 lines, -19 lines) Patch
M src/compiler/bytecode-graph-builder.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/interpreter/bytecode-array-builder.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/interpreter/bytecode-array-builder.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 1 chunk +8 lines, -1 line 0 comments Download
M src/interpreter/bytecodes.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/interpreter/interpreter.cc View 2 chunks +38 lines, -17 lines 0 comments Download
M test/cctest/interpreter/test-bytecode-generator.cc View 1 chunk +69 lines, -0 lines 0 comments Download
M test/cctest/interpreter/test-interpreter.cc View 1 chunk +29 lines, -0 lines 0 comments Download
M test/unittests/interpreter/bytecode-array-builder-unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410853002/1
5 years, 2 months ago (2015-10-16 14:08:15 UTC) #2
rmcilroy
Orion, PTAL, thanks.
5 years, 2 months ago (2015-10-16 14:08:36 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-16 15:06:06 UTC) #6
oth
lgtm. awesome!
5 years, 2 months ago (2015-10-16 16:09:07 UTC) #7
rmcilroy
TBR Benedikt for compiler/bytecode-graph-builder.cc bytecode addition.
5 years, 2 months ago (2015-10-16 16:12:52 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410853002/1
5 years, 2 months ago (2015-10-16 16:13:02 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-16 16:14:28 UTC) #12
commit-bot: I haz the power
5 years, 2 months ago (2015-10-16 16:14:58 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a1e9a6d77fcd3dec7245fef9aba45341eff0d26d
Cr-Commit-Position: refs/heads/master@{#31345}

Powered by Google App Engine
This is Rietveld 408576698