Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1410833009: [heap] Simplify zapping of old optimized code maps. (Closed)

Created:
5 years, 1 month ago by Michael Starzinger
Modified:
5 years, 1 month ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Simplify zapping of old optimized code maps. This unconditionally enables zapping of old optimized code maps and unifies the various zapping paths. The unconditional zapping, even if heap verification is off, is needed because slots in the code map have not been recorded and evacuation invariants break. R=ulan@chromium.org Committed: https://crrev.com/0c1994c64d5327cce706e7ae6bfec8da2ac4c7e4 Cr-Commit-Position: refs/heads/master@{#31895}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -18 lines) Patch
M src/objects.cc View 3 chunks +9 lines, -18 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 1 month ago (2015-11-09 16:51:33 UTC) #1
ulan
lgtm
5 years, 1 month ago (2015-11-09 17:14:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410833009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410833009/1
5 years, 1 month ago (2015-11-09 17:18:14 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-09 17:19:50 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-11-09 17:20:13 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0c1994c64d5327cce706e7ae6bfec8da2ac4c7e4
Cr-Commit-Position: refs/heads/master@{#31895}

Powered by Google App Engine
This is Rietveld 408576698