Issue 141083007: Fix host STUN. Use talk_base::AsyncResolver.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 141083007: Fix host STUN. Use talk_base::AsyncResolver. (Closed)

Created:
6 years, 11 months ago by dcaiafa

Modified:
6 years, 11 months ago

Reviewers:
Sergey Ulanov

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, weitaosu+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix host STUN. Use talk_base::AsyncResolver. StunRequest requires the AsyncResolver object produced by the configured SocketFactory to resolve the address of the STUN server before it can send the STUN requests. ChromiumSocketFactory currently produces DummyAsyncResolver, which doesn't do any resolving. The fix is to provide Libjingle's talk_base::AsyncResolver. BUG=333958 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245437

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -25 lines)			Patch
	M	remoting/jingle_glue/chromium_socket_factory.cc	View		3 chunks	+2 lines, -25 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcaiafa@chromium.org/141083007/1

6 years, 11 months ago (2014-01-17 00:18:30 UTC) #3

Message was sent while issue was closed.

Change committed as 245437

Expand Messages | Collapse Messages