Issue 141083005: Disable context menu on signin page in the embedded flow

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 141083005: Disable context menu on signin page in the embedded flow (Closed)

Created:
6 years, 11 months ago by guohui

Modified:
6 years, 11 months ago

Reviewers:
xiyuan

CC:
chromium-reviews, arv+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Disable context menu on signin page in the embedded flow When chrome signin page is embedded in the avatar bubble, context menu should be disabled, because the only option 'inspect element' would open a debugger window, which then immediately disappears since the avatar bubble auto closes when it loses focus. BUG=313272 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245436

Patch Set 1 : #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	chrome/browser/resources/gaia_auth/OWNERS	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	chrome/browser/resources/gaia_auth/main.js	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

guohui

Hey Xiyuan, could you please take a look at the CL? Thanks, Hui

6 years, 11 months ago (2014-01-16 21:57:28 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/guohui@chromium.org/141083005/20001

6 years, 11 months ago (2014-01-16 22:12:43 UTC) #3

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=247664

6 years, 11 months ago (2014-01-17 00:03:21 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/guohui@chromium.org/141083005/20001

6 years, 11 months ago (2014-01-17 03:03:03 UTC) #5

Message was sent while issue was closed.

Change committed as 245436

Expand Messages | Collapse Messages