Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Unified Diff: core/src/fxge/ge/fx_ge_fontmap.cpp

Issue 1410823005: Take FOXIT_FACE_COUNT and MM_FACE_COUNT constants from xfa (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « core/include/fxge/fx_font.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: core/src/fxge/ge/fx_ge_fontmap.cpp
diff --git a/core/src/fxge/ge/fx_ge_fontmap.cpp b/core/src/fxge/ge/fx_ge_fontmap.cpp
index 08e9d4698c9ad8f5f8c75ed18054e50ebb4e2b47..f318a0ee1b909b122c08da6b08d8803677d5ed06 100644
--- a/core/src/fxge/ge/fx_ge_fontmap.cpp
+++ b/core/src/fxge/ge/fx_ge_fontmap.cpp
@@ -413,7 +413,7 @@ CFX_FontMapper::CFX_FontMapper(CFX_FontMgr* mgr)
FXSYS_memset(m_FoxitFaces, 0, sizeof(m_FoxitFaces));
}
CFX_FontMapper::~CFX_FontMapper() {
- for (int i = 0; i < 14; i++)
+ for (int i = 0; i < FOXIT_FACE_COUNT; i++)
Lei Zhang 2015/10/26 22:11:26 can we use FX_ArraySize() instead?
Lei Zhang 2015/10/26 22:11:26 This for-loop needs braces.
Tom Sepez 2015/10/26 22:26:20 And the inner if doesn't. Also size_t
Tom Sepez 2015/10/26 22:26:20 Done.
if (m_FoxitFaces[i]) {
FXFT_Done_Face(m_FoxitFaces[i]);
}
« no previous file with comments | « core/include/fxge/fx_font.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698