Issue 1410823005: Take FOXIT_FACE_COUNT and MM_FACE_COUNT constants from xfa

Issue 1410823005: Take FOXIT_FACE_COUNT and MM_FACE_COUNT constants from xfa (Closed)

Created:
5 years, 1 month ago by Tom Sepez

Modified:
5 years, 1 month ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Take FOXIT_FACE_COUNT and MM_FACE_COUNT constants from xfa Make master closer to XFA and eliminate some magic numbers. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/d50b640e42d46ab0f4d69cc58b3ba54e6137749c

Patch Set 2 : Comments #

Total comments: 1

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -5 lines)			Patch
	M	core/include/fxge/fx_font.h	View		2 chunks	+5 lines, -2 lines	0 comments	Download
	M	core/src/fxge/ge/fx_ge_fontmap.cpp	View	1	1 chunk	+3 lines, -3 lines	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

lgtm https://codereview.chromium.org/1410823005/diff/1/core/src/fxge/ge/fx_ge_fontmap.cpp File core/src/fxge/ge/fx_ge_fontmap.cpp (right): https://codereview.chromium.org/1410823005/diff/1/core/src/fxge/ge/fx_ge_fontmap.cpp#newcode416 core/src/fxge/ge/fx_ge_fontmap.cpp:416: for (int i = 0; i < FOXIT_FACE_COUNT; ...

5 years, 1 month ago (2015-10-26 22:11:26 UTC) #2

Tom Sepez

https://codereview.chromium.org/1410823005/diff/1/core/src/fxge/ge/fx_ge_fontmap.cpp File core/src/fxge/ge/fx_ge_fontmap.cpp (right): https://codereview.chromium.org/1410823005/diff/1/core/src/fxge/ge/fx_ge_fontmap.cpp#newcode416 core/src/fxge/ge/fx_ge_fontmap.cpp:416: for (int i = 0; i < FOXIT_FACE_COUNT; i++) ...

5 years, 1 month ago (2015-10-26 22:26:20 UTC) #3

Tom Sepez

Committed patchset #2 (id:20001) manually as d50b640e42d46ab0f4d69cc58b3ba54e6137749c (presubmit successful).

5 years, 1 month ago (2015-10-26 22:26:37 UTC) #4

Lei Zhang

5 years, 1 month ago (2015-10-26 22:35:07 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/1410823005/diff/20001/core/src/fxge/ge/fx_ge_...
File core/src/fxge/ge/fx_ge_fontmap.cpp (right):

https://codereview.chromium.org/1410823005/diff/20001/core/src/fxge/ge/fx_ge_...
core/src/fxge/ge/fx_ge_fontmap.cpp:418: FXFT_Done_Face(m_FoxitFaces[i]);
(For later) FT_Done_Face() checks its input, so we don't even have to do that
here. So maybe we don't need those braces after all. Ditto below.

Expand Messages | Collapse Messages