Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Unified Diff: chrome/browser/ui/search_engines/search_engine_tab_helper.cc

Issue 1410823003: Add UMA for window.external.AddSearchProvider (Chrome side). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: mpearson review Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/search_engines/search_engine_tab_helper.cc
diff --git a/chrome/browser/ui/search_engines/search_engine_tab_helper.cc b/chrome/browser/ui/search_engines/search_engine_tab_helper.cc
index 52813e929be410a364045d4e88d01d204c9d05b6..2e5e28805ad47d932d21dd6eebedcefc9954fb55 100644
--- a/chrome/browser/ui/search_engines/search_engine_tab_helper.cc
+++ b/chrome/browser/ui/search_engines/search_engine_tab_helper.cc
@@ -4,10 +4,12 @@
#include "chrome/browser/ui/search_engines/search_engine_tab_helper.h"
+#include "base/metrics/histogram_macros.h"
#include "base/prefs/pref_service.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/search_engines/template_url_fetcher_factory.h"
#include "chrome/browser/search_engines/template_url_service_factory.h"
+#include "chrome/browser/ui/search_engines/edit_search_engine_controller.h"
#include "chrome/browser/ui/search_engines/search_engine_tab_helper_delegate.h"
#include "chrome/common/pref_names.h"
#include "chrome/common/render_messages.h"
@@ -121,6 +123,18 @@ void SearchEngineTabHelper::OnPageHasOSDD(
// necessary uses TemplateURLFetcher to download the OSDD and create a
// keyword.
+ TemplateURLFetcher::ProviderType provider_type =
+ (msg_provider_type == search_provider::AUTODETECTED_PROVIDER)
+ ? TemplateURLFetcher::AUTODETECTED_PROVIDER
+ : TemplateURLFetcher::EXPLICIT_PROVIDER;
+
+ if (provider_type == TemplateURLFetcher::EXPLICIT_PROVIDER) {
+ UMA_HISTOGRAM_ENUMERATION(
+ "Search.AddSearchProvider",
+ EditSearchEngineController::ADD_SEARCH_PROVIDER_CALLED,
+ EditSearchEngineController::NUM_EDIT_SEARCH_ENGINE_ACTIONS);
+ }
+
// Make sure that the page is the current page and other basic checks.
// When |page_url| has file: scheme, this method doesn't work because of
// http://b/issue?id=863583. For that reason, this doesn't check and allow
@@ -135,11 +149,6 @@ void SearchEngineTabHelper::OnPageHasOSDD(
profile->IsOffTheRecord())
return;
- TemplateURLFetcher::ProviderType provider_type =
- (msg_provider_type == search_provider::AUTODETECTED_PROVIDER) ?
- TemplateURLFetcher::AUTODETECTED_PROVIDER :
- TemplateURLFetcher::EXPLICIT_PROVIDER;
-
// If the current page is a form submit, find the last page that was not a
// form submit and use its url to generate the keyword from.
const NavigationController& controller = web_contents()->GetController();
« no previous file with comments | « chrome/browser/ui/search_engines/edit_search_engine_controller.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698