Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 14108007: Introduce the fallback theme engine that will be used to paint a fallback UI (Closed)

Created:
7 years, 8 months ago by keishi
Modified:
7 years, 7 months ago
Reviewers:
tkent, jamesr
CC:
blink-reviews, jamesr, jeez, abarth_chromum.org, jchaffraix+rendering
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Introduce the fallback theme engine that will be used to paint a fallback UI Most native theme widgets don't support zooming and styling. So we will use the fallback theme in these cases. Platform::fallbackThemeEngine(): Added a method that returns the fallback theme. So we can get both the native theme and the default theme. TEST=None. No behavior change yet. BUG=84973 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150182

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : Separating default theme from the fallback theme #

Patch Set 5 : Just add fallback theme engine #

Patch Set 6 : Added to Platform.gypi #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M Source/Platform/Platform.gypi View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M Source/Platform/chromium/public/Platform.h View 1 2 3 4 2 chunks +3 lines, -0 lines 0 comments Download
A + Source/Platform/chromium/public/WebFallbackThemeEngine.h View 1 2 3 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
keishi
7 years, 8 months ago (2013-04-23 10:20:04 UTC) #1
tkent
On 2013/04/23 10:20:04, keishi1 wrote: > Chromium side change: https://codereview.chromium.org/14424007 You can't land this CL ...
7 years, 8 months ago (2013-04-23 12:22:09 UTC) #2
keishi
On 2013/04/23 12:22:09, tkent wrote: > On 2013/04/23 10:20:04, keishi1 wrote: > > Chromium side ...
7 years, 7 months ago (2013-05-09 12:54:31 UTC) #3
tkent
Need to add WebFallbackThemeEngine.h to Platform.gypi.
7 years, 7 months ago (2013-05-09 20:56:22 UTC) #4
keishi
On 2013/05/09 20:56:22, tkent wrote: > Need to add WebFallbackThemeEngine.h to Platform.gypi. Done.
7 years, 7 months ago (2013-05-10 02:25:11 UTC) #5
tkent
lgtm But unfortunately I don't own Platform.gypi.
7 years, 7 months ago (2013-05-10 02:27:31 UTC) #6
keishi
abarth@, could you review the change to Platform.gypi. Thanks.
7 years, 7 months ago (2013-05-10 02:32:37 UTC) #7
jamesr
lgtm
7 years, 7 months ago (2013-05-10 02:54:02 UTC) #8
keishi
On 2013/05/10 02:54:02, jamesr wrote: > lgtm Thanks.
7 years, 7 months ago (2013-05-10 03:09:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keishi@chromium.org/14108007/14001
7 years, 7 months ago (2013-05-10 03:09:49 UTC) #10
commit-bot: I haz the power
Retried try job too often on mac_layout for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout&number=1641
7 years, 7 months ago (2013-05-10 09:26:27 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keishi@chromium.org/14108007/14001
7 years, 7 months ago (2013-05-10 12:13:20 UTC) #12
commit-bot: I haz the power
Retried try job too often on win_layout for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout&number=1778
7 years, 7 months ago (2013-05-10 17:39:19 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keishi@chromium.org/14108007/14001
7 years, 7 months ago (2013-05-13 00:02:53 UTC) #14
commit-bot: I haz the power
7 years, 7 months ago (2013-05-13 00:03:05 UTC) #15
Message was sent while issue was closed.
Change committed as 150182

Powered by Google App Engine
This is Rietveld 408576698