Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1410773008: [Chrome flag] Remove unused chrome flag entry for Suggestions Service (Closed)

Created:
5 years, 2 months ago by Mathieu
Modified:
5 years, 1 month ago
Reviewers:
rkaplow
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chrome flag] Remove unused chrome flag entry for Suggestions Service BUG=None TEST=builds Committed: https://crrev.com/b8b4fdc93d5bbfcbd62f3b407cadce098fbd8e1d Cr-Commit-Position: refs/heads/master@{#356051}

Patch Set 1 : Initial #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -21 lines) Patch
M build/ios/grit_whitelist.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Mathieu
Hi, Please have a look, thanks.
5 years, 2 months ago (2015-10-23 17:39:23 UTC) #4
rkaplow
lgtm
5 years, 1 month ago (2015-10-26 14:28:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410773008/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410773008/20001
5 years, 1 month ago (2015-10-26 14:30:14 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 1 month ago (2015-10-26 15:12:18 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-10-26 15:13:09 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/b8b4fdc93d5bbfcbd62f3b407cadce098fbd8e1d
Cr-Commit-Position: refs/heads/master@{#356051}

Powered by Google App Engine
This is Rietveld 408576698