Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 1410753002: Do not coerce lastIndex of a global RegExp in @@match and @@replace. (Closed)

Created:
5 years, 2 months ago by Yang
Modified:
5 years, 2 months ago
Reviewers:
Dan Ehrenberg, rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Do not coerce lastIndex of a global RegExp in @@match and @@replace. R=rossberg@chromium.org BUG=v8:4471 LOG=N Committed: https://crrev.com/f2bfa12654d79e3d81a011fd98fca7e34ea1d5d2 Cr-Commit-Position: refs/heads/master@{#31330}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -15 lines) Patch
M src/js/string.js View 2 chunks +0 lines, -7 lines 0 comments Download
A test/mjsunit/es6/regexp-match-lastindex.js View 1 chunk +11 lines, -0 lines 0 comments Download
A test/mjsunit/es6/regexp-replace-lastindex.js View 1 chunk +11 lines, -0 lines 0 comments Download
M test/mjsunit/regress/regress-2438.js View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Yang
5 years, 2 months ago (2015-10-16 09:53:23 UTC) #1
rossberg
Not sure what the context of this change is, but otherwise LGTM. ;)
5 years, 2 months ago (2015-10-16 10:03:23 UTC) #2
adamk
+littledan who's working on changes to the RegExp stuff in ES6, in case this is ...
5 years, 2 months ago (2015-10-16 10:11:57 UTC) #4
Dan Ehrenberg
lgtm I think this is a spec change that we want to keep in the ...
5 years, 2 months ago (2015-10-16 10:28:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410753002/1
5 years, 2 months ago (2015-10-16 10:59:36 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-16 11:25:24 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-10-16 11:25:49 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f2bfa12654d79e3d81a011fd98fca7e34ea1d5d2
Cr-Commit-Position: refs/heads/master@{#31330}

Powered by Google App Engine
This is Rietveld 408576698