Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: scripts/slave/recipes/ios/try.py

Issue 1410743010: Rework iOS recipes to use latest MB approach (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: update w/ cleanup Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« scripts/slave/recipe_modules/ios/api.py ('K') | « scripts/slave/recipe_modules/ios/example.expected/clobber.json ('k') | scripts/slave/recipes/ios/try.expected/basic.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipes/ios/try.py
diff --git a/scripts/slave/recipes/ios/try.py b/scripts/slave/recipes/ios/try.py
index 8b11abba83a9bcbc744b317bae27f4b88e88752e..dfb7ddbd6940e24d118d35abe7fffff16fe235d4 100644
--- a/scripts/slave/recipes/ios/try.py
+++ b/scripts/slave/recipes/ios/try.py
@@ -198,7 +198,12 @@ def GenTests(api):
)
+ api.ios.make_test_build_config({
'xcode version': 'fake xcode version',
- 'GYP_DEFINES': {},
+ 'GYP_DEFINES': [],
+ 'gn_args': [
+ 'target_os="ios"',
+ 'ios_enable_code_signing=false',
+ ],
+ 'mb_type': 'gn',
'compiler': 'ninja',
'configuration': 'Debug',
'sdk': 'iphonesimulator8.0',
@@ -209,7 +214,6 @@ def GenTests(api):
'os': '8.1',
},
],
- 'use_mb': True,
})
)
« scripts/slave/recipe_modules/ios/api.py ('K') | « scripts/slave/recipe_modules/ios/example.expected/clobber.json ('k') | scripts/slave/recipes/ios/try.expected/basic.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698