Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1410743009: [turbofan] Avoid some unnecessary write barriers. (Closed)

Created:
5 years, 1 month ago by Benedikt Meurer
Modified:
5 years, 1 month ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Avoid some unnecessary write barriers. Use the type specified for StoreField and StoreElement to check whether we are storing a TaggedSigned value, and skip the write barrier for the write completely in that case. Also make sure to set that field type appropriately for JSGlobalObjectSpecialization. R=jarin@chromium.org BUG=v8:4470 LOG=n Committed: https://crrev.com/bdc950551428c826e60e502304f207b32bf65a83 Cr-Commit-Position: refs/heads/master@{#31772}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -10 lines) Patch
M src/compiler/js-global-object-specialization.cc View 4 chunks +8 lines, -2 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 3 chunks +10 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 1 month ago (2015-11-04 08:44:21 UTC) #1
Benedikt Meurer
Hey Jaro, Here's a simple fix to avoid some stupid write barriers. Please take a ...
5 years, 1 month ago (2015-11-04 08:44:58 UTC) #2
Jarin
lgtm
5 years, 1 month ago (2015-11-04 08:58:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410743009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410743009/1
5 years, 1 month ago (2015-11-04 09:00:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-04 09:09:36 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-04 09:10:15 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bdc950551428c826e60e502304f207b32bf65a83
Cr-Commit-Position: refs/heads/master@{#31772}

Powered by Google App Engine
This is Rietveld 408576698