runtime/vm/flow_graph_type_propagator.cc - Issue 1410733006: More general CHA-based inlining and devirtualization for precompiled code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_type_propagator.cc

Issue 1410733006: More general CHA-based inlining and devirtualization for precompiled code. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: addressed comments, fixed type propagation assertion failure Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_type_propagator.cc

diff --git a/runtime/vm/flow_graph_type_propagator.cc b/runtime/vm/flow_graph_type_propagator.cc

index 2795ffd481e55c23dfcd5741fa1cf833e9c4719f..986615f1b669b0924a459b550a725f229b3ea327 100644

--- a/runtime/vm/flow_graph_type_propagator.cc

+++ b/runtime/vm/flow_graph_type_propagator.cc

@@ -588,7 +588,11 @@ bool CompileType::IsNull() {

const AbstractType* CompileType::ToAbstractType() {

if (type_ == NULL) {

- ASSERT(cid_ != kIllegalCid);

+ // Type propagation has not run. Return dynamic-type.

+ if (cid_ == kIllegalCid) {

+ type_ = &Type::ZoneHandle(Type::DynamicType());

+ return type_;

+ }

// VM-internal objects don't have a compile-type. Return dynamic-type

// in this case.

« no previous file with comments | « runtime/vm/flow_graph_optimizer.cc ('k') | runtime/vm/intermediate_language.h » ('j') | no next file with comments »