runtime/vm/flow_graph_compiler.cc - Issue 1410733006: More general CHA-based inlining and devirtualization for precompiled code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_compiler.cc

Issue 1410733006: More general CHA-based inlining and devirtualization for precompiled code. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: addressed comments, fixed type propagation assertion failure Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_compiler.cc

diff --git a/runtime/vm/flow_graph_compiler.cc b/runtime/vm/flow_graph_compiler.cc

index 8b3750f0cf3900262d8434fcf5a7ced0b9cabb44..79d9e6158730f4c3ed159f0638931ce408669345 100644

--- a/runtime/vm/flow_graph_compiler.cc

+++ b/runtime/vm/flow_graph_compiler.cc

@@ -1098,9 +1098,7 @@ void FlowGraphCompiler::GenerateInstanceCall(

if (is_optimizing() && (ic_data.NumberOfUsedChecks() == 0)) {

// Emit IC call that will count and thus may need reoptimization at

// function entry.

- ASSERT(!is_optimizing()

- || may_reoptimize()

- || flow_graph().IsCompiledForOsr());

+ ASSERT(may_reoptimize() || flow_graph().IsCompiledForOsr());

switch (ic_data.NumArgsTested()) {

case 1:

EmitOptimizedInstanceCall(

« no previous file with comments | « runtime/vm/cha.cc ('k') | runtime/vm/flow_graph_inliner.cc » ('j') | no next file with comments »