More general CHA-based inlining and devirtualization for precompiled code.

runtime/vm/block_scheduler.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/block_scheduler.h"
 
 #include "vm/allocation.h"
 #include "vm/code_patcher.h"
 #include "vm/flow_graph.h"
 
@@ skipping 42 matching lines @@
 }
 
 
 void BlockScheduler::AssignEdgeWeights() const {
   if (!FLAG_emit_edge_counters) {
     return;
   }
 
   const Array& ic_data_array = Array::Handle(flow_graph()->zone(),
       flow_graph()->parsed_function().function().ic_data_array());
+  if (ic_data_array.IsNull()) {
+    // Function was not compiled yet. No edge counters available.
+    return;

[srdjan, 2015/10/21 17:37:46]

When can this happen? In precompilation FLAG_emit_edge_counters is false.

[Florian Schneider, 2015/10/22 13:59:25]

Yes, not needed with precompilation. Left over check when I tried inlining
methods without code with lazy compilation.

+  }
   Array& edge_counters = Array::Handle();
   edge_counters ^= ic_data_array.At(0);
 
   intptr_t entry_count = GetEdgeCount(
       edge_counters,
       flow_graph()->graph_entry()->normal_entry()->preorder_number());
   flow_graph()->graph_entry()->set_entry_count(entry_count);
 
   for (BlockIterator it = flow_graph()->reverse_postorder_iterator();
        !it.Done();
@@ skipping 131 matching lines @@
   for (intptr_t i = block_count - 1; i >= 0; --i) {
     if (chains[i]->first->block == flow_graph()->postorder()[i]) {
       for (Link* link = chains[i]->first; link != NULL; link = link->next) {
         flow_graph()->CodegenBlockOrder(true)->Add(link->block);
       }
     }
   }
 }
 
 }  // namespace dart