Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issue 141073006: Remove special ArrayCode CallIC. (Closed)

Created:
6 years, 11 months ago by Toon Verwaest
Modified:
6 years, 11 months ago
CC:
v8-dev
Visibility:
Public.

Description

Remove special ArrayCode CallIC. Once Call ICs are replaced by LoadIC + CallFunctionStub, we'll need a new way of tracking this information. R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18662

Patch Set 1 #

Patch Set 2 : Disable Array() related tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -235 lines) Patch
M src/arm/stub-cache-arm.cc View 1 chunk +0 lines, -33 lines 0 comments Download
M src/ia32/stub-cache-ia32.cc View 1 chunk +0 lines, -33 lines 0 comments Download
M src/mips/stub-cache-mips.cc View 1 chunk +0 lines, -33 lines 0 comments Download
M src/stub-cache.h View 2 chunks +1 line, -7 lines 0 comments Download
M src/stub-cache.cc View 3 chunks +2 lines, -18 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 1 chunk +0 lines, -33 lines 0 comments Download
M test/mjsunit/array-feedback.js View 1 2 chunks +78 lines, -78 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Toon Verwaest
PTAL
6 years, 11 months ago (2014-01-17 10:26:40 UTC) #1
Benedikt Meurer
Great, LGTM.
6 years, 11 months ago (2014-01-17 10:28:37 UTC) #2
mvstanton
lgtm
6 years, 11 months ago (2014-01-17 11:23:39 UTC) #3
Toon Verwaest
6 years, 11 months ago (2014-01-17 11:24:44 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r18662 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698