Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(916)

Issue 1410723004: [turbofan] Bring back early return in JSInliningHeuristic. (Closed)

Created:
5 years, 1 month ago by Michael Starzinger
Modified:
5 years, 1 month ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Bring back early return in JSInliningHeuristic. This redcues the noise created by --trace-turbo-inlining when there actually are no candidates being processed. R=bmeurer@chromium.org Committed: https://crrev.com/ce1720690ba3af6017cde591bb9faad071685675 Cr-Commit-Position: refs/heads/master@{#31885}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/compiler/js-inlining-heuristic.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 1 month ago (2015-11-09 12:19:38 UTC) #1
Benedikt Meurer
LGTM.
5 years, 1 month ago (2015-11-09 12:58:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410723004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410723004/1
5 years, 1 month ago (2015-11-09 14:13:40 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-09 14:14:45 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-11-09 14:15:22 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ce1720690ba3af6017cde591bb9faad071685675
Cr-Commit-Position: refs/heads/master@{#31885}

Powered by Google App Engine
This is Rietveld 408576698