Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1410703009: Revert of Wire up SDL on Android (Closed)

Created:
5 years, 1 month ago by joshualitt
Modified:
5 years, 1 month ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@sdl
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Wire up SDL on Android (patchset #4 id:60001 of https://codereview.chromium.org/1415453009/ ) Reason for revert: breaks appurify Original issue's description: > Wire up SDL on Android > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/a4d3797c3b0f0cac8493c46cb334ca88a5d6ccf6 TBR=bsalomon@google.com,robertphillips@google.com,joshualitt@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/5d7a7fe5631d87ca3c18d2f75d8402906616c17b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -2267 lines) Patch
M gyp/common_variables.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/views.gyp View 1 chunk +3 lines, -0 lines 0 comments Download
M gyp/visualbench.gyp View 1 chunk +1 line, -1 line 0 comments Download
M include/views/SkOSWindow_SDL.h View 3 chunks +5 lines, -6 lines 0 comments Download
M include/views/SkWindow.h View 1 chunk +1 line, -1 line 0 comments Download
M platform_tools/android/apps/settings.gradle View 1 chunk +0 lines, -1 line 0 comments Download
D platform_tools/android/apps/visualbenchsdl/build.gradle View 1 chunk +0 lines, -47 lines 0 comments Download
D platform_tools/android/apps/visualbenchsdl/src/main/AndroidManifest.xml View 1 chunk +0 lines, -29 lines 0 comments Download
D platform_tools/android/apps/visualbenchsdl/src/main/java/com/skia/VisualBenchActivity.java View 1 chunk +0 lines, -14 lines 0 comments Download
D platform_tools/android/apps/visualbenchsdl/src/main/java/com/skia/VisualBenchTestActivity.java View 1 chunk +0 lines, -62 lines 0 comments Download
D platform_tools/android/apps/visualbenchsdl/src/main/java/org/libsdl/app/SDLActivity.java View 1 chunk +0 lines, -1684 lines 0 comments Download
M platform_tools/android/gyp/dependencies.gypi View 1 chunk +3 lines, -0 lines 0 comments Download
M platform_tools/android/gyp/skia_android.gypi View 2 chunks +0 lines, -67 lines 0 comments Download
M src/views/sdl/SkOSWindow_SDL.cpp View 5 chunks +20 lines, -76 lines 0 comments Download
D third_party/libsdl/android/SDL_config.h View 1 chunk +0 lines, -145 lines 0 comments Download
D third_party/libsdl/android/sdl_android.gypi View 1 chunk +0 lines, -127 lines 0 comments Download
M third_party/libsdl/sdl.gypi View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
joshualitt
Created Revert of Wire up SDL on Android
5 years, 1 month ago (2015-11-05 18:48:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410703009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410703009/1
5 years, 1 month ago (2015-11-05 18:48:34 UTC) #2
commit-bot: I haz the power
5 years, 1 month ago (2015-11-05 18:48:43 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/5d7a7fe5631d87ca3c18d2f75d8402906616c17b

Powered by Google App Engine
This is Rietveld 408576698