Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: chrome/common/extensions/api/tab_capture.idl

Issue 14107010: Update tabCapture API docs with browser action info. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/api/tab_capture.idl
diff --git a/chrome/common/extensions/api/tab_capture.idl b/chrome/common/extensions/api/tab_capture.idl
index cfca548cc1372f8cfa219e87ad67a4d982f72c31..7edc05a7bb31099e9c09e034ad41bf62246bf24e 100644
--- a/chrome/common/extensions/api/tab_capture.idl
+++ b/chrome/common/extensions/api/tab_capture.idl
@@ -47,7 +47,10 @@ namespace tabCapture {
interface Functions {
// Captures the visible area of the currently active tab.
- // Extensions must have the "tabCapture" permission to use this method.
+ // Extensions must have the "tabCapture" permission to use this method. Use
+ // of this method for the currently active tab must also first be "granted"
not at google - send to devlin 2013/04/18 18:29:21 must also first be -> can only be "granted" -> gr
mark a. foltz 2013/04/18 18:30:05 Might say: Use of this method requires that the u
not at google - send to devlin 2013/04/18 18:31:36 Yes - and several other user actions.
mark a. foltz 2013/04/18 18:33:23 Okay, then might say "clicking on the extension" o
justinlin 2013/04/18 20:10:00 Done. Yea, that sounds better.
justinlin 2013/04/18 20:10:00 Just "granted through a user action" like Ben sugg
+ // through a user action of clicking on the extension icon. Note that
+ // Chrome internal pages cannot be captured.
// |options| : Configures the returned media stream.
// |callback| : Callback with either the stream returned or null.
static void capture(CaptureOptions options,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698