Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1410683009: Disable integer division when generating precompiled snapshots for older ARMv7 devices (Closed)

Created:
5 years, 1 month ago by Chinmay
Modified:
5 years, 1 month ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org, abarth
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Disable integer division when generating precompiled snapshots for older ARMv7 devices R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/2bf488f9e753ecd5418799c5f0508856670b46aa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M runtime/bin/gen_snapshot.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Chinmay
5 years, 1 month ago (2015-10-27 21:29:38 UTC) #2
rmacnak
lgtm
5 years, 1 month ago (2015-10-27 21:35:15 UTC) #3
Chinmay
5 years, 1 month ago (2015-10-27 21:38:45 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2bf488f9e753ecd5418799c5f0508856670b46aa.

Powered by Google App Engine
This is Rietveld 408576698