Add type cast definitions for CPDF_Number.

Add type cast definitions for CPDF_Number.

This Cl adds ToNumber, CPDF_Object::AsNumber and CPDF_Object::IsNumber and
updates the src to use them as needed.

BUG=pdfium:201
R=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/83bf02dfb860a66d756434d194118dae572d04d3

[dsinclair, 2015-10-21 13:19:24]

Patchset #1 (id:1) has been deleted

[dsinclair, 2015-10-21 13:21:30]

dsinclair@chromium.org changed reviewers:
+ thestig@chromium.org, tsepez@chromium.org

[dsinclair, 2015-10-21 13:21:30]

PTAL.

I killed off a few extraneous this->As*'s that I'd added while I was in here.

[Lei Zhang, 2015-10-21 14:45:50]

lgtm with a comment for a short discussion.

https://codereview.chromium.org/1410673005/diff/20001/core/include/fpdfapi/fp...
File core/include/fpdfapi/fpdf_objects.h (right):

https://codereview.chromium.org/1410673005/diff/20001/core/include/fpdfapi/fp...
core/include/fpdfapi/fpdf_objects.h:83: bool IsNumber() const { return m_Type ==
PDFOBJ_NUMBER; }
Do we want to do alphabetical order, or PDFOBJ_FOO value order? Darn thing isn't
an enum yet.

https://codereview.chromium.org/1410673005/diff/20001/core/src/fpdfapi/fpdf_p...
File core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp (right):

https://codereview.chromium.org/1410673005/diff/20001/core/src/fpdfapi/fpdf_p...
core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp:251: if (pThis->m_bInteger)
Combine into one ctor call?

return new CPDF_Number(pThis->m_bInteger ? pThis->m_Integer : pThis->m_Float)

https://codereview.chromium.org/1410673005/diff/20001/core/src/fpdfapi/fpdf_p...
File core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp (right):

https://codereview.chromium.org/1410673005/diff/20001/core/src/fpdfapi/fpdf_p...
core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp:48: if (CPDF_Number* pObj =
ToNumber(pDict->GetElement(key)))
drop the if and return pObj ? pObj->GetInteger() : 0; ?

https://codereview.chromium.org/1410673005/diff/20001/core/src/fpdfdoc/doc_ta...
File core/src/fpdfdoc/doc_tagged.cpp (right):

https://codereview.chromium.org/1410673005/diff/20001/core/src/fpdfdoc/doc_ta...
core/src/fpdfdoc/doc_tagged.cpp:455: if (!ToNumber(pAttr))
another opportunity for ternary operator

[dsinclair, 2015-10-21 15:00:11]

https://codereview.chromium.org/1410673005/diff/20001/core/include/fpdfapi/fp...
File core/include/fpdfapi/fpdf_objects.h (right):

https://codereview.chromium.org/1410673005/diff/20001/core/include/fpdfapi/fp...
core/include/fpdfapi/fpdf_objects.h:83: bool IsNumber() const { return m_Type ==
PDFOBJ_NUMBER; }
On 2015/10/21 14:45:50, Lei Zhang wrote:
> Do we want to do alphabetical order, or PDFOBJ_FOO value order? Darn thing
isn't
> an enum yet.


I'm doing alphabetical order as I think it makes the most sense, makes it easy
to see if your entry is in the list without looking at every one of them.

https://codereview.chromium.org/1410673005/diff/20001/core/src/fpdfapi/fpdf_p...
File core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp (right):

https://codereview.chromium.org/1410673005/diff/20001/core/src/fpdfapi/fpdf_p...
core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp:251: if (pThis->m_bInteger)
On 2015/10/21 14:45:50, Lei Zhang wrote:
> Combine into one ctor call?
> 
> return new CPDF_Number(pThis->m_bInteger ? pThis->m_Integer : pThis->m_Float)

Done.

https://codereview.chromium.org/1410673005/diff/20001/core/src/fpdfapi/fpdf_p...
File core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp (right):

https://codereview.chromium.org/1410673005/diff/20001/core/src/fpdfapi/fpdf_p...
core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp:48: if (CPDF_Number* pObj =
ToNumber(pDict->GetElement(key)))
On 2015/10/21 14:45:50, Lei Zhang wrote:
> drop the if and return pObj ? pObj->GetInteger() : 0; ?

Done.

https://codereview.chromium.org/1410673005/diff/20001/core/src/fpdfdoc/doc_ta...
File core/src/fpdfdoc/doc_tagged.cpp (right):

https://codereview.chromium.org/1410673005/diff/20001/core/src/fpdfdoc/doc_ta...
core/src/fpdfdoc/doc_tagged.cpp:455: if (!ToNumber(pAttr))
On 2015/10/21 14:45:50, Lei Zhang wrote:
> another opportunity for ternary operator

Done.

[dsinclair, 2015-10-21 15:01:05]

Committed patchset #2 (id:40001) manually as
83bf02dfb860a66d756434d194118dae572d04d3 (presubmit successful).