Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issue 1410643008: Get rid of deprecated methods accessing mutator_thread_ instead of current thread (Closed)

Created:
5 years, 2 months ago by srdjan
Modified:
5 years, 2 months ago
Reviewers:
zra
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Get rid of deprecated methods accessing mutator_thread_ instead of current thread BUG= R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/b9426418d8f5d5d248f5dca6838fbad333abe3c6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -81 lines) Patch
M runtime/vm/allocation.h View 1 chunk +0 lines, -7 lines 0 comments Download
M runtime/vm/allocation_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/base_isolate.h View 1 chunk +0 lines, -3 lines 0 comments Download
M runtime/vm/dart_api_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/dart_api_impl.cc View 9 chunks +9 lines, -9 lines 0 comments Download
M runtime/vm/exceptions.cc View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/heap.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/isolate.h View 1 chunk +0 lines, -20 lines 0 comments Download
M runtime/vm/isolate.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/object.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/object_graph.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/object_graph.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M runtime/vm/object_graph_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/parser.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/report.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/service.cc View 6 chunks +11 lines, -10 lines 0 comments Download
M runtime/vm/snapshot.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/snapshot.cc View 5 chunks +8 lines, -6 lines 0 comments Download
M runtime/vm/stack_frame.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/timer.h View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
srdjan
Get rid of deprecated methods (the one using isolate instead of thread), move StackResource to ...
5 years, 2 months ago (2015-10-20 16:46:06 UTC) #2
zra
lgtm QQ: Is it documented somewhere when/where it is safe for a worker thread to ...
5 years, 2 months ago (2015-10-20 17:13:19 UTC) #3
srdjan
On 2015/10/20 17:13:19, zra wrote: > lgtm > > QQ: Is it documented somewhere when/where ...
5 years, 2 months ago (2015-10-20 17:22:23 UTC) #4
srdjan
5 years, 2 months ago (2015-10-20 17:26:38 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b9426418d8f5d5d248f5dca6838fbad333abe3c6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698