net/url_request/url_request_test_job.h - Issue 1410643007: URLRequestJob: change ReadRawData contract

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/url_request/url_request_test_job.h

Issue 1410643007: URLRequestJob: change ReadRawData contract (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address David's comments Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/url_request/url_request_test_job.h

diff --git a/net/url_request/url_request_test_job.h b/net/url_request/url_request_test_job.h

index 09b31a41e2cf787f718f071c1d68c8e31dfa2d94..eb1db01660e241a36a0d1604e44d284434030317 100644

--- a/net/url_request/url_request_test_job.h

+++ b/net/url_request/url_request_test_job.h

@@ -111,7 +111,7 @@ class NET_EXPORT_PRIVATE URLRequestTestJob : public URLRequestJob {

// Job functions

void SetPriority(RequestPriority priority) override;

void Start() override;

- bool ReadRawData(IOBuffer* buf, int buf_size, int* bytes_read) override;

+ int ReadRawData(IOBuffer* buf, int buf_size) override;

void Kill() override;

bool GetMimeType(std::string* mime_type) const override;

void GetResponseInfo(HttpResponseInfo* info) override;