net/url_request/url_request_simple_job.h - Issue 1410643007: URLRequestJob: change ReadRawData contract

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/url_request/url_request_simple_job.h

Issue 1410643007: URLRequestJob: change ReadRawData contract (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address David's comments Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/url_request/url_request_simple_job.h

diff --git a/net/url_request/url_request_simple_job.h b/net/url_request/url_request_simple_job.h

index 6c9d5e8b929f4daf8297036c4624db0d0aa4b643..06f718e71ee600fe587b05bcc3555b970ecdfa8c 100644

--- a/net/url_request/url_request_simple_job.h

+++ b/net/url_request/url_request_simple_job.h

@@ -28,7 +28,7 @@ class NET_EXPORT URLRequestSimpleJob : public URLRangeRequestJob {

void Start() override;

void Kill() override;

- bool ReadRawData(IOBuffer* buf, int buf_size, int* bytes_read) override;

+ int ReadRawData(IOBuffer* buf, int buf_size) override;

bool GetMimeType(std::string* mime_type) const override;

bool GetCharset(std::string* charset) override;

@@ -66,7 +66,6 @@ class NET_EXPORT URLRequestSimpleJob : public URLRangeRequestJob {

private:

void OnGetDataCompleted(int result);

- void OnReadCompleted(int bytes_read);

HttpByteRange byte_range_;

std::string mime_type_;