URLRequestJob: change ReadRawData contract

content/browser/fileapi/file_writer_delegate_unittest.cc

Index: content/browser/fileapi/file_writer_delegate_unittest.cc
diff --git a/content/browser/fileapi/file_writer_delegate_unittest.cc b/content/browser/fileapi/file_writer_delegate_unittest.cc
index c9bcfbb7177a2a530c28db3c42e5163a94ba93b4..e4221bcaedcf2764e0b901180d9f2fd5e4716fe8 100644
--- a/content/browser/fileapi/file_writer_delegate_unittest.cc
+++ b/content/browser/fileapi/file_writer_delegate_unittest.cc
@@ -10,6 +10,7 @@
 #include "base/bind_helpers.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/location.h"
+#include "base/numerics/safe_conversions.h"

[davidben, 2015/11/03 22:50:05]

Unused?

[xunjieli, 2015/11/04 01:26:51]

Done.

 #include "base/run_loop.h"
 #include "base/single_thread_task_runner.h"
 #include "base/thread_task_runner_handle.h"
@@ -184,7 +185,7 @@ class FileWriterDelegateTestJob : public net::URLRequestJob {
         base::Bind(&FileWriterDelegateTestJob::NotifyHeadersComplete, this));
   }
 
-  bool ReadRawData(net::IOBuffer* buf, int buf_size, int* bytes_read) override {
+  int ReadRawData(net::IOBuffer* buf, int buf_size) override {
     if (remaining_bytes_ < buf_size)
       buf_size = static_cast<int>(remaining_bytes_);

[davidben, 2015/11/03 22:50:05]

[Existing issue, but the static_cast<int> doesn't seem to do anything.
remaining_bytes_ is already an int.]

[xunjieli, 2015/11/04 01:26:51]

Done.

 
@@ -192,9 +193,7 @@ class FileWriterDelegateTestJob : public net::URLRequestJob {
       buf->data()[i] = content_[cursor_++];
     remaining_bytes_ -= buf_size;
 
-    SetStatus(net::URLRequestStatus());
-    *bytes_read = buf_size;
-    return true;
+    return buf_size;
   }
 
   int GetResponseCode() const override { return 200; }