Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Unified Diff: content/browser/service_worker/service_worker_write_to_cache_job.h

Issue 1410643007: URLRequestJob: change ReadRawData contract (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move NotifyReadCompleted Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_write_to_cache_job.h
diff --git a/content/browser/service_worker/service_worker_write_to_cache_job.h b/content/browser/service_worker/service_worker_write_to_cache_job.h
index deee1070fd9ce8a3c85077ba86fb01a989b3429f..7adf09e9b6e6542215d4796925154cf96a78b0f0 100644
--- a/content/browser/service_worker/service_worker_write_to_cache_job.h
+++ b/content/browser/service_worker/service_worker_write_to_cache_job.h
@@ -71,7 +71,7 @@ class CONTENT_EXPORT ServiceWorkerWriteToCacheJob
void GetResponseInfo(net::HttpResponseInfo* info) override;
int GetResponseCode() const override;
void SetExtraRequestHeaders(const net::HttpRequestHeaders& headers) override;
- bool ReadRawData(net::IOBuffer* buf, int buf_size, int* bytes_read) override;
+ int ReadRawData(net::IOBuffer* buf, int buf_size) override;
const net::HttpResponseInfo* http_info() const;
@@ -114,10 +114,10 @@ class CONTENT_EXPORT ServiceWorkerWriteToCacheJob
// status to IO_PENDING. After this function returns, if the URLRequestJob
// isn't IO_PENDING, all of the data in |io_buffer_| has been written back to
// the script cache if necessary.
- void HandleNetData(int bytes_read);
+ int HandleNetData(int bytes_read);
- void NotifyDoneHelper(const net::URLRequestStatus& status,
- const std::string& status_message);
+ void NotifyStartErrorHelper(const net::URLRequestStatus& status,
+ const std::string& status_message);
void NotifyFinishedCaching(net::URLRequestStatus status,
const std::string& status_message);
@@ -140,6 +140,7 @@ class CONTENT_EXPORT ServiceWorkerWriteToCacheJob
bool has_been_killed_;
bool did_notify_started_;
bool did_notify_finished_;
+
base::WeakPtrFactory<ServiceWorkerWriteToCacheJob> weak_factory_;
DISALLOW_COPY_AND_ASSIGN(ServiceWorkerWriteToCacheJob);

Powered by Google App Engine
This is Rietveld 408576698