content/browser/fileapi/mock_url_request_delegate.cc - Issue 1410643007: URLRequestJob: change ReadRawData contract

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/fileapi/mock_url_request_delegate.cc

Issue 1410643007: URLRequestJob: change ReadRawData contract (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Move NotifyReadCompleted Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/fileapi/mock_url_request_delegate.cc

diff --git a/content/browser/fileapi/mock_url_request_delegate.cc b/content/browser/fileapi/mock_url_request_delegate.cc

index 0c1735c90b433ce52374f1f92fb6c9715877a654..d52d57e8837d3cc77e25e3eb2c715a0efc1218a3 100644

--- a/content/browser/fileapi/mock_url_request_delegate.cc

+++ b/content/browser/fileapi/mock_url_request_delegate.cc

@@ -5,6 +5,7 @@

#include "content/browser/fileapi/mock_url_request_delegate.h"

#include "base/run_loop.h"

+#include "base/thread_task_runner_handle.h"

#include "net/base/io_buffer.h"

#include "testing/gtest/include/gtest/gtest.h"

@@ -66,7 +67,8 @@ void MockURLRequestDelegate::ReceiveData(net::URLRequest* request,

}

void MockURLRequestDelegate::RequestComplete() {

- base::MessageLoop::current()->QuitWhenIdle();

+ base::ThreadTaskRunnerHandle::Get()->PostTask(

+ FROM_HERE, base::MessageLoop::QuitWhenIdleClosure());

mmenke 2015/10/28 16:40:42 Why is this change part of this CL?

xunjieli 2015/10/28 21:11:52 Done.

}

} // namespace