content/browser/android/url_request_content_job.h - Issue 1410643007: URLRequestJob: change ReadRawData contract

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/android/url_request_content_job.h

Issue 1410643007: URLRequestJob: change ReadRawData contract (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Self review Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/android/url_request_content_job.h

diff --git a/content/browser/android/url_request_content_job.h b/content/browser/android/url_request_content_job.h

index 5d3d9336acc44e2f6367bb6e653fa4cd652fb108..78b3ea6b6fc3f83fd1cb1667df9a5d03acb407f8 100644

--- a/content/browser/android/url_request_content_job.h

+++ b/content/browser/android/url_request_content_job.h

@@ -42,7 +42,7 @@ class CONTENT_EXPORT URLRequestContentJob : public net::URLRequestJob {

// net::URLRequestJob:

void Start() override;

void Kill() override;

- bool ReadRawData(net::IOBuffer* buf, int buf_size, int* bytes_read) override;

+ int ReadRawData(net::IOBuffer* buf, int buf_size) override;

bool IsRedirectResponse(GURL* location, int* http_status_code) override;

bool GetMimeType(std::string* mime_type) const override;

void SetExtraRequestHeaders(const net::HttpRequestHeaders& headers) override;

@@ -89,6 +89,7 @@ class CONTENT_EXPORT URLRequestContentJob : public net::URLRequestJob {

const scoped_refptr<base::TaskRunner> content_task_runner_;

net::HttpByteRange byte_range_;

+ net::Error range_parse_result_;

int64 remaining_bytes_;

bool io_pending_;