android_webview/browser/net/android_stream_reader_url_request_job.h - Issue 1410643007: URLRequestJob: change ReadRawData contract

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/browser/net/android_stream_reader_url_request_job.h

Issue 1410643007: URLRequestJob: change ReadRawData contract (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Self review Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | android_webview/browser/net/android_stream_reader_url_request_job.cc » ('j') | android_webview/browser/net/android_stream_reader_url_request_job.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/browser/net/android_stream_reader_url_request_job.h

diff --git a/android_webview/browser/net/android_stream_reader_url_request_job.h b/android_webview/browser/net/android_stream_reader_url_request_job.h

index e21d7655b9aca8049a471b653d73d4b344160d57..3d559202c15dbef569cf39dd15bc9abc2c39511f 100644

--- a/android_webview/browser/net/android_stream_reader_url_request_job.h

+++ b/android_webview/browser/net/android_stream_reader_url_request_job.h

@@ -96,7 +96,7 @@ class AndroidStreamReaderURLRequestJob : public net::URLRequestJob {

// URLRequestJob:

void Start() override;

void Kill() override;

- bool ReadRawData(net::IOBuffer* buf, int buf_size, int* bytes_read) override;

+ int ReadRawData(net::IOBuffer* buf, int buf_size) override;

void SetExtraRequestHeaders(const net::HttpRequestHeaders& headers) override;

bool GetMimeType(std::string* mime_type) const override;

bool GetCharset(std::string* charset) override;

@@ -131,6 +131,7 @@ class AndroidStreamReaderURLRequestJob : public net::URLRequestJob {

void OnReaderReadCompleted(int bytes_read);

net::HttpByteRange byte_range_;

+ net::Error range_parse_result_;

scoped_ptr<net::HttpResponseInfo> response_info_;

scoped_ptr<Delegate> delegate_;

scoped_ptr<DelegateObtainer> delegate_obtainer_;