Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 1410643003: Add a public API for the results of constant evaluation (Closed)

Created:
5 years, 2 months ago by Brian Wilkerson
Modified:
5 years, 2 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add a public API for the results of constant evaluation R=paulberry@google.com Committed: https://github.com/dart-lang/sdk/commit/204ee60bd0019cbca821677457ac91c7547e282b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+371 lines, -110 lines) Patch
M pkg/analyzer/lib/src/generated/constant.dart View 11 chunks +253 lines, -35 lines 0 comments Download
M pkg/analyzer/lib/src/generated/element.dart View 10 chunks +39 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/element_handle.dart View 2 chunks +12 lines, -8 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 7 chunks +12 lines, -11 lines 0 comments Download
M pkg/analyzer/test/generated/all_the_rest_test.dart View 14 chunks +51 lines, -51 lines 0 comments Download
M pkg/analyzer/test/src/task/dart_test.dart View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Brian Wilkerson
5 years, 2 months ago (2015-10-16 19:54:39 UTC) #2
Paul Berry
lgtm
5 years, 2 months ago (2015-10-16 20:53:41 UTC) #3
Brian Wilkerson
5 years, 2 months ago (2015-10-17 14:51:15 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
204ee60bd0019cbca821677457ac91c7547e282b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698