[turbofan] Implement the call protocol properly for direct calls.

[turbofan] Implement the call protocol properly for direct calls.

The callees are expected to properly set the number of actual
arguments passed to the callee, which is now represented correctly
in the TurboFan graphs by a new Parameter right before the context
Parameter.  Currently this is only being used for outgoing calls.

Note that this requires disabling two of the TF code stub tests,
because of the JavaScript graphs are not automagically compatible
with abitrary (incoming) code stub interface descriptors.  If we
want to support JS code stubs at all, then we need to find a sane
way to feed in this information.

Drive-by-fix: Don't insert a direct call to a classConstructor.

R=mstarzinger@chromium.org
BUG=v8:4413, v8:4428
LOG=n

Committed: https://crrev.com/30aca03ad104e748a0d4d55a93fdcf76ea9f302a
Cr-Commit-Position: refs/heads/master@{#31789}

[Benedikt Meurer, 2015-11-04 13:29:32]

Hey Michi,

This is the CL we were looking into.
Please take a look.

Thanks,
Benedikt

Camillo, Danno: FYI

[Benedikt Meurer, 2015-11-04 13:35:41]

Description was changed from

==========
[turbofan] Implement the call protocol properly for direct calls.

The callees are expected to properly set the number of actual
arguments passed to the callee, which is now represented correctly
in the TurboFan graphs by a new Parameter right before the context
Parameter.  Currently this is only being used for outgoing calls.

Note that this requires disabling two of the TF code stub tests,
because of the JavaScript graphs are not automagically compatible
with abitrary (incoming) code stub interface descriptors.  If we
want to support JS code stubs at all, then we need to find a sane
way to feed in this information.

Drive-by-fix: Don't insert a direct call to a classConstructor.

R=mstarzinger@chromium.org
BUG=v8:4413
LOG=n
==========

to

==========
[turbofan] Implement the call protocol properly for direct calls.

The callees are expected to properly set the number of actual
arguments passed to the callee, which is now represented correctly
in the TurboFan graphs by a new Parameter right before the context
Parameter.  Currently this is only being used for outgoing calls.

Note that this requires disabling two of the TF code stub tests,
because of the JavaScript graphs are not automagically compatible
with abitrary (incoming) code stub interface descriptors.  If we
want to support JS code stubs at all, then we need to find a sane
way to feed in this information.

Drive-by-fix: Don't insert a direct call to a classConstructor.

R=mstarzinger@chromium.org
BUG=v8:4413, v8:4428
LOG=n
==========

[Michael Starzinger, 2015-11-04 13:43:14]

LGTM, only nits, modulo unit test failures.

https://codereview.chromium.org/1410633006/diff/1/src/compiler/js-inlining.cc
File src/compiler/js-inlining.cc (right):

https://codereview.chromium.org/1410633006/diff/1/src/compiler/js-inlining.cc...
src/compiler/js-inlining.cc:139: // Context is last argument.
nit: s/argument/parameter/ here.

https://codereview.chromium.org/1410633006/diff/1/src/compiler/js-inlining.cc...
src/compiler/js-inlining.cc:158: Replace(use,
jsgraph_->Int32Constant(inliner_inputs - 2));
nit: Can we add a comment "// The projection is requesting the number of
arguments." here?

https://codereview.chromium.org/1410633006/diff/1/src/compiler/js-inlining.cc...
src/compiler/js-inlining.cc:282: // See ES6 section 9.2.1 [[Call]] (
thisArgument, argumentsList).
nit: Parenthesis look weird, can we add a trailing space before the closing one?

https://codereview.chromium.org/1410633006/diff/1/src/compiler/js-typed-lower...
File src/compiler/js-typed-lowering.cc (right):

https://codereview.chromium.org/1410633006/diff/1/src/compiler/js-typed-lower...
src/compiler/js-typed-lowering.cc:1594: // See ES6 section 9.2.1 [[Call]] (
thisArgument, argumentsList).
nit: Parenthesis look weird, can we add a trailing space before the closing one?

https://codereview.chromium.org/1410633006/diff/1/src/compiler/linkage.cc
File src/compiler/linkage.cc (right):

https://codereview.chromium.org/1410633006/diff/1/src/compiler/linkage.cc#new...
src/compiler/linkage.cc:403: // Add JavaScript call argument count.
nit: empty newline before this block?

[Benedikt Meurer, 2015-11-04 13:51:09]

Done, thx.

https://codereview.chromium.org/1410633006/diff/1/src/compiler/js-inlining.cc
File src/compiler/js-inlining.cc (right):

https://codereview.chromium.org/1410633006/diff/1/src/compiler/js-inlining.cc...
src/compiler/js-inlining.cc:139: // Context is last argument.
On 2015/11/04 13:43:14, Michael Starzinger wrote:
> nit: s/argument/parameter/ here.

Done.

https://codereview.chromium.org/1410633006/diff/1/src/compiler/js-inlining.cc...
src/compiler/js-inlining.cc:158: Replace(use,
jsgraph_->Int32Constant(inliner_inputs - 2));
On 2015/11/04 13:43:14, Michael Starzinger wrote:
> nit: Can we add a comment "// The projection is requesting the number of
> arguments." here?

Done.

https://codereview.chromium.org/1410633006/diff/1/src/compiler/js-inlining.cc...
src/compiler/js-inlining.cc:282: // See ES6 section 9.2.1 [[Call]] (
thisArgument, argumentsList).
On 2015/11/04 13:43:14, Michael Starzinger wrote:
> nit: Parenthesis look weird, can we add a trailing space before the closing
one?

Done.

https://codereview.chromium.org/1410633006/diff/1/src/compiler/js-typed-lower...
File src/compiler/js-typed-lowering.cc (right):

https://codereview.chromium.org/1410633006/diff/1/src/compiler/js-typed-lower...
src/compiler/js-typed-lowering.cc:1594: // See ES6 section 9.2.1 [[Call]] (
thisArgument, argumentsList).
On 2015/11/04 13:43:14, Michael Starzinger wrote:
> nit: Parenthesis look weird, can we add a trailing space before the closing
one?

Done.

https://codereview.chromium.org/1410633006/diff/1/src/compiler/linkage.cc
File src/compiler/linkage.cc (right):

https://codereview.chromium.org/1410633006/diff/1/src/compiler/linkage.cc#new...
src/compiler/linkage.cc:403: // Add JavaScript call argument count.
On 2015/11/04 13:43:14, Michael Starzinger wrote:
> nit: empty newline before this block?

Done.

[Benedikt Meurer, 2015-11-04 13:51:16]

The CQ bit was checked by bmeurer@chromium.org

[Benedikt Meurer, 2015-11-04 13:51:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1410633006/#ps20001
(title: "Address comments.")

[commit-bot: I haz the power, 2015-11-04 13:51:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1410633006/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1410633006/20001

[commit-bot: I haz the power, 2015-11-04 14:08:50]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-04 14:09:11]

Patchset 2 (id:??) landed as
https://crrev.com/30aca03ad104e748a0d4d55a93fdcf76ea9f302a
Cr-Commit-Position: refs/heads/master@{#31789}