[heap] Base number of compaction tasks on live memory and compaction speed.

src/heap/gc-tracer.h

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_HEAP_GC_TRACER_H_
 #define V8_HEAP_GC_TRACER_H_
 
 #include "src/base/platform/platform.h"
 #include "src/globals.h"
 
@@ skipping 160 matching lines @@
     // Time spent in the mutator during the end of the last sample to the
     // beginning of the next sample.
     double duration_;
 
     // Memory allocated in the new space during the end of the last sample
     // to the beginning of the next sample
     size_t allocation_in_bytes_;
   };
 
 
+  class CompactionEvent {
+   public:
+    CompactionEvent() : duration(0), live_bytes_compacted(0) {}
+
+    CompactionEvent(double duration, intptr_t live_bytes_compacted)
+        : duration(duration), live_bytes_compacted(live_bytes_compacted) {}
+
+    double duration;
+    intptr_t live_bytes_compacted;
+  };
+
+
   class ContextDisposalEvent {
    public:
     // Default constructor leaves the event uninitialized.
     ContextDisposalEvent() {}
 
     explicit ContextDisposalEvent(double time);
 
     // Time when context disposal event happened.
     double time_;
   };
@@ skipping 116 matching lines @@
 
   static const size_t kRingBufferMaxSize = 10;
 
   typedef RingBuffer<Event, kRingBufferMaxSize> EventBuffer;
 
   typedef RingBuffer<AllocationEvent, kRingBufferMaxSize> AllocationEventBuffer;
 
   typedef RingBuffer<ContextDisposalEvent, kRingBufferMaxSize>
       ContextDisposalEventBuffer;
 
+  typedef RingBuffer<CompactionEvent, kRingBufferMaxSize> CompactionEventBuffer;
+
   typedef RingBuffer<SurvivalEvent, kRingBufferMaxSize> SurvivalEventBuffer;
 
   static const int kThroughputTimeFrameMs = 5000;
 
   explicit GCTracer(Heap* heap);
 
   // Start collecting data.
   void Start(GarbageCollector collector, const char* gc_reason,
              const char* collector_reason);
 
   // Stop collecting data and print results.
   void Stop(GarbageCollector collector);
 
   // Sample and accumulate bytes allocated since the last GC.
   void SampleAllocation(double current_ms, size_t new_space_counter_bytes,
                         size_t old_generation_counter_bytes);
 
   // Log the accumulated new space allocation bytes.
   void AddAllocation(double current_ms);
 
   void AddContextDisposalTime(double time);
 
+  void AddCompactionEvent(double duration, intptr_t live_bytes_compacted);
+
   void AddSurvivalRatio(double survival_ratio);
 
   // Log an incremental marking step.
   void AddIncrementalMarkingStep(double duration, intptr_t bytes);
 
   // Log time spent in marking.
   void AddMarkingTime(double duration) {
     cumulative_marking_duration_ += duration;
   }
 
@@ skipping 50 matching lines @@
 
   // Compute the average incremental marking speed in bytes/millisecond.
   // Returns 0 if no events have been recorded.
   intptr_t IncrementalMarkingSpeedInBytesPerMillisecond() const;
 
   // Compute the average scavenge speed in bytes/millisecond.
   // Returns 0 if no events have been recorded.
   intptr_t ScavengeSpeedInBytesPerMillisecond(
       ScavengeSpeedMode mode = kForAllObjects) const;
 
+  intptr_t CompactionSpeedInBytesPerMillisecond() const;

[Hannes Payer (out of office), 2015/11/03 04:08:17]

Add comment, like others.

[Michael Lippautz, 2015/11/03 20:57:42]

Done.

+
   // Compute the average mark-sweep speed in bytes/millisecond.
   // Returns 0 if no events have been recorded.
   intptr_t MarkCompactSpeedInBytesPerMillisecond() const;
 
   // Compute the average incremental mark-sweep finalize speed in
   // bytes/millisecond.
   // Returns 0 if no events have been recorded.
   intptr_t FinalIncrementalMarkCompactSpeedInBytesPerMillisecond() const;
 
   // Compute the overall mark compact speed including incremental steps
@@ skipping 94 matching lines @@
   // RingBuffers for INCREMENTAL_MARK_COMPACTOR events.
   EventBuffer incremental_mark_compactor_events_;
 
   // RingBuffer for allocation events.
   AllocationEventBuffer new_space_allocation_events_;
   AllocationEventBuffer old_generation_allocation_events_;
 
   // RingBuffer for context disposal events.
   ContextDisposalEventBuffer context_disposal_events_;
 
+  CompactionEventBuffer compaction_events_;

[Hannes Payer (out of office), 2015/11/03 04:08:17]

Comment.

[Michael Lippautz, 2015/11/03 20:57:42]

Done.

+
   // RingBuffer for survival events.
   SurvivalEventBuffer survival_events_;
 
   // Cumulative number of incremental marking steps since creation of tracer.
   int cumulative_incremental_marking_steps_;
 
   // Cumulative size of incremental marking steps (in bytes) since creation of
   // tracer.
   intptr_t cumulative_incremental_marking_bytes_;
 
@@ skipping 34 matching lines @@
 
   // Counts how many tracers were started without stopping.
   int start_counter_;
 
   DISALLOW_COPY_AND_ASSIGN(GCTracer);
 };
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_HEAP_GC_TRACER_H_