Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 1410633002: Add flush to output to try to diagnose locks failure (Closed)

Created:
5 years, 2 months ago by scottmg
Modified:
5 years, 2 months ago
Reviewers:
Mark Mentovai
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

Add flush to output to try to diagnose locks failure end_to_end_test.py started failing after landing https://codereview.chromium.org/1392093003/ but I'm not sure why. It seems https://build.chromium.org/p/client.crashpad/builders/crashpad_win_x64_dbg/builds/45/steps/run%20tests/logs/stdio to be aborting in a place that doesn't make much sense, so try adding flushes to see if there's output getting lost. R=mark@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/71cc0a28a4960ba050c0be05b36b870df9d20348

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M snapshot/win/end_to_end_test.py View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
scottmg
5 years, 2 months ago (2015-10-15 21:57:55 UTC) #1
Mark Mentovai
LGTM
5 years, 2 months ago (2015-10-15 22:00:08 UTC) #2
scottmg
Committed patchset #2 (id:20001) manually as 71cc0a28a4960ba050c0be05b36b870df9d20348 (presubmit successful).
5 years, 2 months ago (2015-10-15 22:03:27 UTC) #3
scottmg
Well. https://build.chromium.org/p/client.crashpad/builders/crashpad_win_x86_wow64_dbg/builds/51/steps/run%20tests/logs/stdio 1) I am glad we have this test; 2) I have no idea ...
5 years, 2 months ago (2015-10-15 22:10:12 UTC) #4
scottmg
On 2015/10/15 22:10:12, scottmg wrote: > Well. > > https://build.chromium.org/p/client.crashpad/builders/crashpad_win_x86_wow64_dbg/builds/51/steps/run%20tests/logs/stdio > > 1) I am ...
5 years, 2 months ago (2015-10-15 22:30:14 UTC) #5
Mark Mentovai
5 years, 2 months ago (2015-10-15 22:33:08 UTC) #6
Message was sent while issue was closed.
The fact that it couldn’t do that at all is also troubling.

Powered by Google App Engine
This is Rietveld 408576698