Issue 141063002: Revert of Convert the re2 GYP targets to be generated by GN.

Issue 141063002: Revert of Convert the re2 GYP targets to be generated by GN. (Closed)

Created:
6 years, 11 months ago by brettw

Modified:
6 years, 11 months ago

Reviewers:
bradnelson, bradn

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, Dirk Pranke

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Revert of Convert the re2 GYP targets to be generated by GN. (https://codereview.chromium.org/68853015/) Reason for revert: Broke Blink compile Original issue's description: > Convert the re2 GYP targets to be generated by GN. > > BUG=288991 > R=bradnelson@google.com > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245254 TBR=bradnelson@chromium.org,bradnelson@google.com NOTREECHECKS=true NOTRY=true BUG=288991 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245271

Patch Set 1 #

Created: 6 years, 11 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+177 lines, -91 lines)			Patch
M	build/all.gyp	View	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome_browser_chromeos.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome_browser_extensions.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome_browser_ui.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome_common.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome_renderer.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/tools/profile_reset/jtl_compiler.gyp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	components/plugins.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download
M	components/url_matcher.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/content_browser.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download
M	extensions/extensions.gyp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	gpu/command_buffer_service.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download
M	gpu/gpu_config.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/leveldatabase/leveldatabase.gyp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/libaddressinput/libaddressinput.gyp	View	1 chunk	+1 line, -1 line	0 comments	Download
D	third_party/re2/BUILD.gn	View	1 chunk	+0 lines, -75 lines	0 comments	Download
A	third_party/re2/re2.gyp	View	1 chunk	+84 lines, -0 lines	0 comments	Download
A	tools/gn/secondary/third_party/re2/BUILD.gn	View	1 chunk	+77 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

brettw

Created Revert of Convert the re2 GYP targets to be generated by GN.

6 years, 11 months ago (2014-01-16 18:44:05 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/141063002/1

6 years, 11 months ago (2014-01-16 18:47:50 UTC) #2

Message was sent while issue was closed.

Change committed as 245271

Expand Messages | Collapse Messages