Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Side by Side Diff: src/x64/debug-x64.cc

Issue 14106011: Allow setting debugger breakpoints on CompareNilICs (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/debug-ia32.cc ('k') | test/cctest/test-debug.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 215 matching lines...) Expand 10 before | Expand all | Expand 10 after
226 // ----------- S t a t e ------------- 226 // ----------- S t a t e -------------
227 // -- rax : value 227 // -- rax : value
228 // -- rcx : key 228 // -- rcx : key
229 // -- rdx : receiver 229 // -- rdx : receiver
230 // ----------------------------------- 230 // -----------------------------------
231 Generate_DebugBreakCallHelper( 231 Generate_DebugBreakCallHelper(
232 masm, rax.bit() | rcx.bit() | rdx.bit(), 0, false); 232 masm, rax.bit() | rcx.bit() | rdx.bit(), 0, false);
233 } 233 }
234 234
235 235
236 void Debug::GenerateCompareNilICDebugBreak(MacroAssembler* masm) {
237 // Register state for CompareNil IC
238 // ----------- S t a t e -------------
239 // -- rax : value
240 // -----------------------------------
241 Generate_DebugBreakCallHelper(masm, rax.bit(), 0, false);
242 }
243
244
236 void Debug::GenerateCallICDebugBreak(MacroAssembler* masm) { 245 void Debug::GenerateCallICDebugBreak(MacroAssembler* masm) {
237 // Register state for IC call call (from ic-x64.cc) 246 // Register state for IC call call (from ic-x64.cc)
238 // ----------- S t a t e ------------- 247 // ----------- S t a t e -------------
239 // -- rcx: function name 248 // -- rcx: function name
240 // ----------------------------------- 249 // -----------------------------------
241 Generate_DebugBreakCallHelper(masm, rcx.bit(), 0, false); 250 Generate_DebugBreakCallHelper(masm, rcx.bit(), 0, false);
242 } 251 }
243 252
244 253
245 void Debug::GenerateReturnDebugBreak(MacroAssembler* masm) { 254 void Debug::GenerateReturnDebugBreak(MacroAssembler* masm) {
(...skipping 99 matching lines...) Expand 10 before | Expand all | Expand 10 after
345 354
346 const bool Debug::kFrameDropperSupported = true; 355 const bool Debug::kFrameDropperSupported = true;
347 356
348 #undef __ 357 #undef __
349 358
350 #endif // ENABLE_DEBUGGER_SUPPORT 359 #endif // ENABLE_DEBUGGER_SUPPORT
351 360
352 } } // namespace v8::internal 361 } } // namespace v8::internal
353 362
354 #endif // V8_TARGET_ARCH_X64 363 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/ia32/debug-ia32.cc ('k') | test/cctest/test-debug.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698