Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 1410573008: Add PassPaintVisualRectToCompositor feature flag. (Closed)

Created:
5 years, 1 month ago by wkorman
Modified:
5 years, 1 month ago
Reviewers:
chrishtr, pdr., vmpstr
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add PassPaintVisualRectToCompositor feature flag. BUG=529938 Committed: https://crrev.com/e8cc107c99f8dea17c02c677270e4e8af3f943c7 Cr-Commit-Position: refs/heads/master@{#357052}

Patch Set 1 #

Patch Set 2 : Add depends_on. #

Patch Set 3 : Remove depends_on. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 21 (7 generated)
wkorman
5 years, 1 month ago (2015-10-28 23:57:37 UTC) #2
wkorman
Chris, this flag should depends_on=SlimmingPaintSynchronizedPainting right?
5 years, 1 month ago (2015-10-29 00:06:57 UTC) #4
chrishtr
On 2015/10/29 at 00:06:57, wkorman wrote: > Chris, this flag should depends_on=SlimmingPaintSynchronizedPainting right? No I ...
5 years, 1 month ago (2015-10-29 00:38:05 UTC) #5
wkorman
On 2015/10/29 at 00:38:05, chrishtr wrote: > On 2015/10/29 at 00:06:57, wkorman wrote: > > ...
5 years, 1 month ago (2015-10-29 02:26:27 UTC) #6
vmpstr
Cool, lgtm.
5 years, 1 month ago (2015-10-29 20:48:47 UTC) #7
chrishtr
lgtm
5 years, 1 month ago (2015-10-29 20:50:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410573008/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410573008/40001
5 years, 1 month ago (2015-10-29 20:50:55 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/88889)
5 years, 1 month ago (2015-10-29 22:17:47 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410573008/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410573008/40001
5 years, 1 month ago (2015-10-29 22:21:39 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/127978)
5 years, 1 month ago (2015-10-30 01:56:11 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410573008/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410573008/40001
5 years, 1 month ago (2015-10-30 04:08:13 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-10-30 08:19:28 UTC) #19
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/e8cc107c99f8dea17c02c677270e4e8af3f943c7 Cr-Commit-Position: refs/heads/master@{#357052}
5 years, 1 month ago (2015-10-30 08:20:40 UTC) #20
perkj_chrome
5 years, 1 month ago (2015-10-30 10:17:31 UTC) #21
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1424783004/ by perkj@chromium.org.

The reason for reverting is: Tentative revert since it seems to break
http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%....

cc_unittests

ThreadedChannelTestCommit.RunMultiThread_DirectRenderer..

Powered by Google App Engine
This is Rietveld 408576698