Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 1410573005: Memory leak fix. Use correct analysis context for annotation constants. (Closed)

Created:
5 years, 1 month ago by scheglov
Modified:
5 years, 1 month ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Memory leak fix. Use correct analysis context for annotation constants. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/e2f905e11d731a2d3b808cd0a824b447cef227e7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -2 lines) Patch
M pkg/analyzer/lib/src/generated/constant.dart View 2 chunks +10 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/all_the_rest_test.dart View 2 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 1 month ago (2015-10-27 17:43:20 UTC) #1
Brian Wilkerson
LGTM
5 years, 1 month ago (2015-10-27 17:59:09 UTC) #2
scheglov
5 years, 1 month ago (2015-10-27 18:04:32 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e2f905e11d731a2d3b808cd0a824b447cef227e7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698