Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 1410573003: X87: Vector ICs: Get rid of stack arguments on ia32 transitioning stores. (Closed)

Created:
5 years, 2 months ago by zhengxing.li
Modified:
5 years, 1 month ago
Reviewers:
Weiliang, chunyang.dai
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Vector ICs: Get rid of stack arguments on ia32 transitioning stores. port 2d4aeaad2fa3888c5e4cbfd30f6338e1fbf794e9 (r31204). original commit message: The stack manipulation was expensive. Two virtual registers are better. BUG= Committed: https://crrev.com/562047df0ff96e5e4c048662a01edf28eed59195 Cr-Commit-Position: refs/heads/master@{#31504}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -51 lines) Patch
M src/ic/x87/handler-compiler-x87.cc View 1 chunk +10 lines, -12 lines 0 comments Download
M src/ic/x87/stub-cache-x87.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x87/code-stubs-x87.cc View 5 chunks +42 lines, -26 lines 0 comments Download
M src/x87/interface-descriptors-x87.cc View 2 chunks +2 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
zhengxing.li
5 years, 2 months ago (2015-10-23 09:08:00 UTC) #2
Weiliang
lgtm
5 years, 2 months ago (2015-10-23 09:11:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410573003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410573003/1
5 years, 2 months ago (2015-10-23 09:11:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-23 09:49:59 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-10-23 09:50:39 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/562047df0ff96e5e4c048662a01edf28eed59195
Cr-Commit-Position: refs/heads/master@{#31504}

Powered by Google App Engine
This is Rietveld 408576698