Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1147)

Unified Diff: remoting/webapp/crd/js/host_screen.js

Issue 1410563006: [Chromoting] SessionLogger refactor. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/webapp/crd/js/desktop_remoting_activity.js ('k') | remoting/webapp/crd/js/it2me_activity.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/webapp/crd/js/host_screen.js
diff --git a/remoting/webapp/crd/js/host_screen.js b/remoting/webapp/crd/js/host_screen.js
index 56890d70fd48a48c1437cf1659d00c0f1a1553da..0f2025ae82a551afed4416ba9ef3d5002987b77e 100644
--- a/remoting/webapp/crd/js/host_screen.js
+++ b/remoting/webapp/crd/js/host_screen.js
@@ -38,9 +38,7 @@ var it2meLogger = null;
remoting.tryShare = function() {
it2meLogger = createLogger_();
it2meLogger.logSessionStateChange(
- remoting.ChromotingEvent.SessionState.STARTED,
- remoting.ChromotingEvent.ConnectionError.NONE,
- null);
+ remoting.ChromotingEvent.SessionState.STARTED);
/** @type {remoting.It2MeHostFacade} */
var hostFacade = new remoting.It2MeHostFacade();
@@ -94,9 +92,7 @@ remoting.tryShareWithToken_ = function(hostFacade, token) {
onNatTraversalPolicyChanged_(true); // Hide warning by default.
remoting.setMode(remoting.AppMode.HOST_WAITING_FOR_CODE);
it2meLogger.logSessionStateChange(
- remoting.ChromotingEvent.SessionState.CONNECTING,
- remoting.ChromotingEvent.ConnectionError.NONE,
- null);
+ remoting.ChromotingEvent.SessionState.CONNECTING);
document.getElementById('cancel-share-button').disabled = false;
disableTimeoutCountdown_();
@@ -210,18 +206,14 @@ function showShareError_(error) {
if (error.hasTag(remoting.Error.Tag.CANCELLED)) {
remoting.setMode(remoting.AppMode.HOME);
it2meLogger.logSessionStateChange(
- remoting.ChromotingEvent.SessionState.CONNECTION_CANCELED,
- remoting.ChromotingEvent.ConnectionError.NONE,
- null);
+ remoting.ChromotingEvent.SessionState.CONNECTION_CANCELED);
} else {
var errorDiv = document.getElementById('host-plugin-error');
l10n.localizeElementFromTag(errorDiv, error.getTag());
console.error('Sharing error: ' + error.toString());
remoting.setMode(remoting.AppMode.HOST_SHARE_FAILED);
it2meLogger.logSessionStateChange(
- remoting.ChromotingEvent.SessionState.CONNECTION_FAILED,
- error.toConnectionError(),
- null);
+ remoting.ChromotingEvent.SessionState.CONNECTION_FAILED, error);
}
cleanUp();
@@ -253,9 +245,7 @@ remoting.cancelShare = function() {
try {
hostSession_.disconnect();
it2meLogger.logSessionStateChange(
- remoting.ChromotingEvent.SessionState.CONNECTION_CANCELED,
- remoting.ChromotingEvent.ConnectionError.NONE,
- null);
+ remoting.ChromotingEvent.SessionState.CONNECTION_CANCELED);
} catch (/** @type {*} */ error) {
console.error('Error disconnecting: ' + error +
'. The host probably crashed.');
« no previous file with comments | « remoting/webapp/crd/js/desktop_remoting_activity.js ('k') | remoting/webapp/crd/js/it2me_activity.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698