Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Unified Diff: remoting/webapp/base/js/telemetry_event_writer_unittest.js

Issue 1410563006: [Chromoting] SessionLogger refactor. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/webapp/base/js/session_logger_unittest.js ('k') | remoting/webapp/base/js/xmpp_error_cache.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/webapp/base/js/telemetry_event_writer_unittest.js
diff --git a/remoting/webapp/base/js/telemetry_event_writer_unittest.js b/remoting/webapp/base/js/telemetry_event_writer_unittest.js
index cf41c9fa3ddfdf09188afd3e3dce515f8dcabd6e..0a17ae6daa1e2230f908f6265dcd3fdd6ad5ad18 100644
--- a/remoting/webapp/base/js/telemetry_event_writer_unittest.js
+++ b/remoting/webapp/base/js/telemetry_event_writer_unittest.js
@@ -92,8 +92,7 @@ QUnit.test('should send CANCELED event when window is closed while started.',
chrome.app.window.current().id = 'fake-window-id';
}).then(function() {
logger.logSessionStateChange(
- remoting.ChromotingEvent.SessionState.STARTED,
- remoting.ChromotingEvent.ConnectionError.NONE);
+ remoting.ChromotingEvent.SessionState.STARTED);
}).then(function() {
return service.unbindSession('fake-window-id');
}).then(function() {
@@ -119,8 +118,8 @@ QUnit.test('should send CANCELED event when window is closed while connecting.',
return service.init().then(function() {
chrome.app.window.current().id = 'fake-window-id';
}).then(function() {
- logger.logClientSessionStateChange(
- remoting.ClientSession.State.CONNECTING, remoting.Error.none(), null);
+ logger.logSessionStateChange(
+ remoting.ChromotingEvent.SessionState.CONNECTING);
}).then(function() {
return service.unbindSession('fake-window-id');
}).then(function() {
@@ -147,11 +146,11 @@ QUnit.test('should send CLOSED event when window is closed while connected.',
return service.init().then(function() {
chrome.app.window.current().id = 'fake-window-id';
}).then(function() {
- logger.logClientSessionStateChange(
- remoting.ClientSession.State.CONNECTING, remoting.Error.none(), null);
+ logger.logSessionStateChange(
+ remoting.ChromotingEvent.SessionState.CONNECTING);
}).then(function() {
- logger.logClientSessionStateChange(
- remoting.ClientSession.State.CONNECTED, remoting.Error.none(), null);
+ logger.logSessionStateChange(
+ remoting.ChromotingEvent.SessionState.CONNECTED);
}).then(function() {
return service.unbindSession('fake-window-id');
}).then(function() {
@@ -180,11 +179,11 @@ QUnit.test('should not send CLOSED event when window is closed unconnected.',
return service.init().then(function() {
chrome.app.window.current().id = 'fake-window-id';
}).then(function() {
- logger.logClientSessionStateChange(
- remoting.ClientSession.State.CONNECTING, remoting.Error.none(), null);
+ logger.logSessionStateChange(
+ remoting.ChromotingEvent.SessionState.CONNECTING);
}).then(function() {
- logger.logClientSessionStateChange(
- remoting.ClientSession.State.FAILED, remoting.Error.none(), null);
+ logger.logSessionStateChange(
+ remoting.ChromotingEvent.SessionState.CONNECTION_FAILED);
}).then(function() {
return service.unbindSession('fake-window-id');
}).then(function() {
« no previous file with comments | « remoting/webapp/base/js/session_logger_unittest.js ('k') | remoting/webapp/base/js/xmpp_error_cache.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698