Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(671)

Unified Diff: remoting/webapp/base/js/client_session_unittest.js

Issue 1410563006: [Chromoting] SessionLogger refactor. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/webapp/base/js/client_session_factory.js ('k') | remoting/webapp/base/js/session_logger.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/webapp/base/js/client_session_unittest.js
diff --git a/remoting/webapp/base/js/client_session_unittest.js b/remoting/webapp/base/js/client_session_unittest.js
index f4a3c99be76f8f6f1139332a3847ed1d9a92460e..6f6273a7e36532966d12852d0ac976d2d1a35e40 100644
--- a/remoting/webapp/base/js/client_session_unittest.js
+++ b/remoting/webapp/base/js/client_session_unittest.js
@@ -76,7 +76,7 @@ QUnit.module('ClientSession', {
listener = new SessionListener();
logger = new remoting.SessionLogger(remoting.ChromotingEvent.Role.CLIENT,
base.doNothing);
- logToServerStub = sinon.stub(logger, 'logClientSessionStateChange');
+ logToServerStub = sinon.stub(logger, 'logSessionStateChange');
},
afterEach: function() {
session.dispose();
@@ -121,13 +121,13 @@ QUnit.test(
'Connection error after CONNECTED should raise the CONNECTION_DROPPED event',
function(assert) {
- var State = remoting.ClientSession.State;
+ var State = remoting.ChromotingEvent.SessionState;
return connect().then(function() {
var onDisconnected = sinon.stub(listener, 'onDisconnected');
session.disconnect(new remoting.Error(remoting.Error.Tag.P2P_FAILURE));
assert.equal(onDisconnected.callCount, 1);
- assert.equal(logToServerStub.args[2][0], State.CONNECTION_DROPPED);
+ assert.equal(logToServerStub.args[4][0], State.CONNECTION_DROPPED);
});
});
@@ -136,14 +136,14 @@ QUnit.test(
function(assert) {
var PluginError = remoting.ClientSession.ConnectionError;
- var State = remoting.ClientSession.State;
+ var State = remoting.ChromotingEvent.SessionState;
return connect(PluginError.SESSION_REJECTED).then(function() {
assert.ok(false, 'Expect connection to fail');
}).catch(function(/** remoting.Error */ error) {
assert.ok(error.hasTag(remoting.Error.Tag.INVALID_ACCESS_CODE));
- assert.equal(logToServerStub.args[1][0], State.FAILED);
- var errorLogged = /** @type {remoting.Error} */(logToServerStub.args[1][1]);
+ assert.equal(logToServerStub.args[3][0], State.CONNECTION_FAILED);
+ var errorLogged = /** @type {remoting.Error} */(logToServerStub.args[3][1]);
assert.equal(errorLogged.getTag(), remoting.Error.Tag.INVALID_ACCESS_CODE);
});
});
« no previous file with comments | « remoting/webapp/base/js/client_session_factory.js ('k') | remoting/webapp/base/js/session_logger.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698