[Chromoting] SessionLogger refactor.

remoting/webapp/crd/js/me2me_activity.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /** @suppress {duplicate} */
 var remoting = remoting || {};
 
 (function() {
 
 'use strict';
@@ skipping 36 matching lines @@
   base.dispose(this.networkDetector_);
   this.networkDetector_ = null;
 };
 
 remoting.Me2MeActivity.prototype.start = function() {
   var webappVersion = chrome.runtime.getManifest().version;
   var that = this;
 
   var Event = remoting.ChromotingEvent;
   this.logger_ = this.createLogger_(Event.SessionEntryPoint.CONNECT_BUTTON);
-  this.logger_.logSessionStateChange(Event.SessionState.STARTED,
-                                     Event.ConnectionError.NONE);
-
-  var errorTag = Event.ConnectionError.NONE;
+  this.logger_.logSessionStateChange(Event.SessionState.STARTED);
 
   function handleError(/** remoting.Error */ error) {
     if (error.isCancel()) {
       remoting.setMode(remoting.AppMode.HOME);
-      that.logger_.logSessionStateChange(Event.SessionState.CONNECTION_CANCELED,
-                                         errorTag);
+      that.logger_.logSessionStateChange(
+          Event.SessionState.CONNECTION_CANCELED);
     } else {
-      that.logger_.logSessionStateChange(Event.SessionState.CONNECTION_FAILED,
-                                         error.toConnectionError());
+      that.logger_.logSessionStateChange(
+          Event.SessionState.CONNECTION_FAILED, error);
       that.showErrorMessage_(error);
     }
   }
 
   this.hostUpdateDialog_.showIfNecessary(webappVersion).then(function() {
     return that.host_.options.load();
   }).catch(remoting.Error.handler(function(/** remoting.Error */ error) {
     // User cancels out of the Host upgrade dialog.  Report it as bad version.
-    errorTag = Event.ConnectionError.BAD_VERSION;
-    throw error;
+    throw new remoting.Error(remoting.Error.Tag.BAD_VERSION);
   })).then(
     this.connect_.bind(this)
   ).catch(remoting.Error.handler(handleError));
 };
 
 remoting.Me2MeActivity.prototype.stop = function() {
   if (this.desktopActivity_) {
     this.desktopActivity_.stop();
   }
 };
@@ skipping 21 matching lines @@
   return logger;
 };
 
 /**
  * @param {remoting.ChromotingEvent.SessionEntryPoint} entryPoint
  * @private
  */
 remoting.Me2MeActivity.prototype.reconnect_ = function(entryPoint) {
   this.logger_ = this.createLogger_(entryPoint);
   var Event = remoting.ChromotingEvent;
-  this.logger_.logSessionStateChange(Event.SessionState.STARTED,
-                                     Event.ConnectionError.NONE);
+  this.logger_.logSessionStateChange(Event.SessionState.STARTED);
   this.connect_();
 };
 
 /**
  * @private
  */
 remoting.Me2MeActivity.prototype.connect_ = function() {
   base.dispose(this.desktopActivity_);
   this.desktopActivity_ =
       new remoting.DesktopRemotingActivity(this, this.logger_);
@@ skipping 284 matching lines @@
       clientName = 'Linux';
     } else {
       console.log('Unrecognized client platform. Using navigator.platform.');
       clientName = navigator.platform;
     }
     plugin.requestPairing(clientName, onPairingComplete);
   }
 };
 
 })();