[Chromoting] SessionLogger refactor.

remoting/webapp/crd/js/host_screen.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * Functions related to the 'host screen' for Chromoting.
  */
 
 /** @suppress {duplicate} */
@@ skipping 20 matching lines @@
 
 /**
  * Start a host session. This is the main entry point for the host screen,
  * called directly from the onclick action of a button on the home screen.
  * It first verifies that the native host components are installed and asks
  * to install them if necessary.
  */
 remoting.tryShare = function() {
   it2meLogger = createLogger_();
   it2meLogger.logSessionStateChange(
-      remoting.ChromotingEvent.SessionState.STARTED,
-      remoting.ChromotingEvent.ConnectionError.NONE,
-      null);
+      remoting.ChromotingEvent.SessionState.STARTED);
 
   /** @type {remoting.It2MeHostFacade} */
   var hostFacade = new remoting.It2MeHostFacade();
 
   /** @type {remoting.HostInstallDialog} */
   var hostInstallDialog = null;
 
   var tryInitializeFacade = function() {
     hostFacade.initialize(onFacadeInitialized, onFacadeInitializationFailed);
   };
@@ skipping 33 matching lines @@
  * @param {remoting.It2MeHostFacade} hostFacade An initialized
  *     It2MeHostFacade.
  * @param {string} token The OAuth access token.
  * @private
  */
 remoting.tryShareWithToken_ = function(hostFacade, token) {
   lastShareWasCancelled_ = false;
   onNatTraversalPolicyChanged_(true);  // Hide warning by default.
   remoting.setMode(remoting.AppMode.HOST_WAITING_FOR_CODE);
   it2meLogger.logSessionStateChange(
-      remoting.ChromotingEvent.SessionState.CONNECTING,
-      remoting.ChromotingEvent.ConnectionError.NONE,
-      null);
+      remoting.ChromotingEvent.SessionState.CONNECTING);
   document.getElementById('cancel-share-button').disabled = false;
   disableTimeoutCountdown_();
 
   console.assert(hostSession_ === null, '|hostSession_| already exists.');
   hostSession_ = new remoting.HostSession();
   remoting.identity.getEmail().then(
       function(/** string */ email) {
         hostSession_.connect(
             hostFacade, email, token, onHostStateChanged_,
             onNatTraversalPolicyChanged_, logDebugInfo_, it2meConnectFailed_);
@@ skipping 93 matching lines @@
 /**
  * Show a host-side error message.
  *
  * @param {!remoting.Error} error The error to be localized and displayed.
  * @return {void} Nothing.
  */
 function showShareError_(error) {
   if (error.hasTag(remoting.Error.Tag.CANCELLED)) {
     remoting.setMode(remoting.AppMode.HOME);
     it2meLogger.logSessionStateChange(
-        remoting.ChromotingEvent.SessionState.CONNECTION_CANCELED,
-        remoting.ChromotingEvent.ConnectionError.NONE,
-        null);
+        remoting.ChromotingEvent.SessionState.CONNECTION_CANCELED);
   } else {
     var errorDiv = document.getElementById('host-plugin-error');
     l10n.localizeElementFromTag(errorDiv, error.getTag());
     console.error('Sharing error: ' + error.toString());
     remoting.setMode(remoting.AppMode.HOST_SHARE_FAILED);
     it2meLogger.logSessionStateChange(
-        remoting.ChromotingEvent.SessionState.CONNECTION_FAILED,
-        error.toConnectionError(),
-        null);
+        remoting.ChromotingEvent.SessionState.CONNECTION_FAILED, error);
   }
 
   cleanUp();
 }
 
 /**
  * Show a sharing error with error code UNEXPECTED .
  *
  * @return {void} Nothing.
  */
@@ skipping 11 matching lines @@
  *
  * @return {void} Nothing.
  */
 remoting.cancelShare = function() {
   document.getElementById('cancel-share-button').disabled = true;
   console.log('Canceling share...');
   remoting.lastShareWasCancelled = true;
   try {
     hostSession_.disconnect();
     it2meLogger.logSessionStateChange(
-        remoting.ChromotingEvent.SessionState.CONNECTION_CANCELED,
-        remoting.ChromotingEvent.ConnectionError.NONE,
-        null);
+        remoting.ChromotingEvent.SessionState.CONNECTION_CANCELED);
   } catch (/** @type {*} */ error) {
     console.error('Error disconnecting: ' + error +
                   '. The host probably crashed.');
     // TODO(jamiewalch): Clean this up. We should have a class representing
     // the host plugin, like we do for the client, which should handle crash
     // reporting and it should use a more detailed error message than the
     // default 'generic' one. See crbug.com/94624
     showShareError_(remoting.Error.unexpected());
   }
   disableTimeoutCountdown_();
@@ skipping 103 matching lines @@
 function createLogger_() {
   // Create a new logger for each session to refresh the session id.
   var logger = new remoting.SessionLogger(
       remoting.ChromotingEvent.Role.HOST,
       remoting.TelemetryEventWriter.Client.write);
   logger.setLogEntryMode(remoting.ChromotingEvent.Mode.IT2ME);
   return logger;
 }
 
 })();