[Chromoting] SessionLogger refactor.

remoting/webapp/base/js/xmpp_error_cache.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 
 /** @suppress {duplicate} */
 var remoting = remoting || {};
 
 (function() {
 
 'use strict';
 
 /**
  * This class monitors incoming XMPP stanza and records the first
  * error encountered.  It also strips all PII from the error stanza,
  * so that it can be uploaded to the cloud for error analysis.
  *
  * @constructor
  */
 
 remoting.XmppErrorCache = function() {
-  /** @private {remoting.ChromotingEvent.XmppError} */
-  this.firstError_ = null;
+  /** @private {string} */
+  this.firstErrorStanza_ = '';

[kelvinp, 2015/11/07 04:44:11]

convert to a string so that it can fit in the error details field.

 };
 
 /**
- * @return {remoting.ChromotingEvent.XmppError} The first XMPP error that the
- *     monitor encountered.  Returns null if no errors have been encountered so
- *     far.
+ * @return {string} The first XMPP error stanza that the monitor encountered.
+ *     Returns an empty string if no errors have been encountered so far.
  */
-remoting.XmppErrorCache.prototype.getFirstError = function() {
-  return this.firstError_;
+remoting.XmppErrorCache.prototype.getFirstErrorStanza = function() {
+  return this.firstErrorStanza_;
 };
 
 /**
  * Monitor the incoming stanza for error.
  *
  * @param {Element} iqNode
  */
 remoting.XmppErrorCache.prototype.processStanza = function(iqNode) {
-  if (this.firstError_ != null) {
+  if (this.firstErrorStanza_ != '') {
     return;
   }
   // The XML structure is as follows:
   // <iq type='error'>
   //   <jingle action='session-accept'/>
   //   <error type='modify' code=''/>
   // </iq>
   if (iqNode.getAttribute('type') != 'error') {
     return;
   }
 
   var strippedStanza = this.stripPII_(iqNode);
-  this.firstError_ = new remoting.ChromotingEvent.XmppError(strippedStanza);
+  this.firstErrorStanza_ = strippedStanza;
 };
 
 /**
  * @param {Element} iqNode
  * @return {string} Return a string representation of |iqNode| with all PII
  *    removed.
  * @private
  */
 remoting.XmppErrorCache.prototype.stripPII_ = function(iqNode) {
   var parser = new DOMParser();
@@ skipping 66 matching lines @@
   var children = node.children;
   for (i = 0; i < children.length; i++) {
     var child = /** @type{Element}*/ (children[i]);
     var childCopy = outNode.ownerDocument.createElement(child.tagName);
     outNode.appendChild(childCopy);
     stripPII(child, childCopy);
   }
 }
 
 })();