[Chromoting] SessionLogger refactor.

remoting/webapp/base/js/error.js

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 /** @suppress {duplicate} */
 var remoting = remoting || {};
 
 /**
@@ skipping 19 matching lines @@
 remoting.Error.prototype.toString = function() {
   var result = this.tag_;
   if (this.detail_ != null) {
     result += ' (' + this.detail_ + ')';
   }
   return result;
 };
 
 /**
  * @return {remoting.ChromotingEvent.ConnectionError} error
+ *
+ * @private
  */
-remoting.Error.prototype.toConnectionError = function() {
+remoting.Error.prototype.toConnectionError_ = function() {
   var Tag = remoting.Error.Tag;
   var ConnectionError = remoting.ChromotingEvent.ConnectionError;
   switch (this.tag_) {
     case Tag.NONE:
       return ConnectionError.NONE;
     case Tag.CLIENT_SUSPENDED:
       return ConnectionError.CLIENT_SUSPENDED;
     case Tag.INVALID_ACCESS_CODE:
       return ConnectionError.INVALID_ACCESS_CODE;
     case Tag.MISSING_PLUGIN:
@@ skipping 43 matching lines @@
 };
 
 /**
  * @return {?string} The detail string passed to the constructor, if any.
  */
 remoting.Error.prototype.getDetail = function() {
   return this.detail_;
 };
 
 /**
+ * Populates the corresponding field in the |logEntry| based on the error tag.
+ *
+ * @param {remoting.ChromotingEvent} logEntry
+ */
+remoting.Error.prototype.fillLogEntry = function(logEntry) {
+  logEntry.connection_error = this.toConnectionError_();
+
+  var Tag = remoting.Error.Tag;
+  var detail = /** @type{string} */ (this.getDetail());

[kelvinp, 2015/11/07 04:44:11]

This extra variable is needed to cast getDetail() into a non-nullabale string.

[Jamie, 2015/11/09 18:46:02]

Nit: Space after "@type"

[kelvinp, 2015/11/09 22:59:10]

Done.

+
+  switch (this.tag_) {
+    case Tag.HOST_IS_OFFLINE:
+      if (detail) {
+        logEntry.xmpp_error = new remoting.ChromotingEvent.XmppError(detail);
+      }
+      break;
+    case Tag.MISSING_PLUGIN:
+      console.assert(detail, 'Missing PNaCl plugin last error string.');
+      logEntry.raw_plugin_error = detail;
+  }
+};
+
+/**
  * Checks the type of an error.
  * @param {remoting.Error.Tag} tag
  * @param {...remoting.Error.Tag} var_args
  * @return {boolean} True if this object has one of the specified tags.
  * @suppress {reportUnknownTypes}
  */
 remoting.Error.prototype.hasTag = function(tag, var_args) {
   var thisTag = this.tag_;
   return Array.prototype.some.call(
       arguments,
@@ skipping 114 matching lines @@
 remoting.Error.handler = function(onError) {
   return function(/** * */ error) {
     if (error instanceof remoting.Error) {
       onError(/** @type {!remoting.Error} */ (error));
     } else {
       console.error('Unexpected error:', error);
       onError(remoting.Error.unexpected());
     }
   };
 };