Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 1410553007: Make SkImageFilter::applyCropRect() optionally compute srcBounds. (Closed)

Created:
5 years, 1 month ago by Stephen White
Modified:
5 years, 1 month ago
Reviewers:
robertphillips, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make SkImageFilter::applyCropRect() optionally compute srcBounds. BUG=skia:4526 Committed: https://skia.googlesource.com/skia/+/4449398b324a7d6226a71e766561ace0028b5153

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fix comment per review #

Patch Set 3 : Tweak comment per review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -11 lines) Patch
M include/core/SkImageFilter.h View 1 2 1 chunk +10 lines, -6 lines 0 comments Download
M src/core/SkImageFilter.cpp View 1 chunk +9 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (3 generated)
Stephen White
reed@: PTAL. This is just the SkImageFilter::applyCropRect() change broken out from https://codereview.chromium.org/1415653003/.
5 years, 1 month ago (2015-10-28 18:57:31 UTC) #2
reed1
https://codereview.chromium.org/1410553007/diff/1/include/core/SkImageFilter.h File include/core/SkImageFilter.h (right): https://codereview.chromium.org/1410553007/diff/1/include/core/SkImageFilter.h#newcode372 include/core/SkImageFilter.h:372: * If srcBounds is non-null, it will be returned ...
5 years, 1 month ago (2015-10-28 19:27:31 UTC) #4
Stephen White
https://codereview.chromium.org/1410553007/diff/1/include/core/SkImageFilter.h File include/core/SkImageFilter.h (right): https://codereview.chromium.org/1410553007/diff/1/include/core/SkImageFilter.h#newcode372 include/core/SkImageFilter.h:372: * If srcBounds is non-null, it will be returned ...
5 years, 1 month ago (2015-10-28 20:17:21 UTC) #5
reed1
Thanks, that helps (I wonder if pseudo code in the comment would work) BTW -- ...
5 years, 1 month ago (2015-10-28 20:29:00 UTC) #6
Stephen White
On 2015/10/28 20:29:00, reed1 wrote: > Thanks, that helps (I wonder if pseudo code in ...
5 years, 1 month ago (2015-10-28 20:36:58 UTC) #7
reed1
Ah, glad I asked :) Lets mention that in the comment as well. I know ...
5 years, 1 month ago (2015-10-28 20:50:30 UTC) #8
Stephen White
On 2015/10/28 20:50:30, reed1 wrote: > Ah, glad I asked :) Lets mention that in ...
5 years, 1 month ago (2015-10-28 20:51:12 UTC) #9
reed1
Of course, so please ask for pointed improvements to the documentation as you run across ...
5 years, 1 month ago (2015-10-28 20:53:48 UTC) #10
reed1
I think the failure is mine (not fully groking imagefilters), but comments definitely help.
5 years, 1 month ago (2015-10-28 20:54:33 UTC) #11
Stephen White
On 2015/10/28 20:50:30, reed1 wrote: > Ah, glad I asked :) Lets mention that in ...
5 years, 1 month ago (2015-10-28 20:56:01 UTC) #12
reed1
thanks lgtm
5 years, 1 month ago (2015-10-28 21:02:15 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410553007/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410553007/40001
5 years, 1 month ago (2015-10-28 21:02:52 UTC) #15
commit-bot: I haz the power
5 years, 1 month ago (2015-10-28 21:17:19 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/4449398b324a7d6226a71e766561ace0028b5153

Powered by Google App Engine
This is Rietveld 408576698