Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 1410553005: Introducing a lint server plugin. (Closed)

Created:
5 years, 1 month ago by pquitslund
Modified:
5 years, 1 month ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Introducing a lint server plugin. Avoids introducing an unwanted dependency on the options plugin to server (efects discovered: https://codereview.chromium.org/1411313005/). Also soon to be future home for fixes and completions. BUG= R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/52fb3b3babd3595539ca4872475948c462e9a6d1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -2 lines) Patch
A pkg/analysis_server/lib/src/plugin/linter_plugin.dart View 1 chunk +36 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/server/driver.dart View 3 chunks +2 lines, -1 line 0 comments Download
M pkg/analysis_server/test/analysis/notification_analysis_options_test.dart View 1 chunk +17 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/analysis_abstract.dart View 2 chunks +6 lines, -1 line 0 comments Download
M pkg/analysis_server/test/services/test_all.dart View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
pquitslund
5 years, 1 month ago (2015-10-26 18:09:05 UTC) #2
Brian Wilkerson
LGTM
5 years, 1 month ago (2015-10-26 18:14:42 UTC) #3
pquitslund
5 years, 1 month ago (2015-10-26 19:11:42 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
52fb3b3babd3595539ca4872475948c462e9a6d1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698