Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1410543007: [turbofan] Re-enable webkit test that no longer fail. (Closed)

Created:
5 years, 2 months ago by Michael Starzinger
Modified:
5 years, 2 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Re-enable webkit test that no longer fail. R=bmeurer@chromium.org TEST=webkit/fast/js/toString-number Committed: https://crrev.com/bfdfb4884810a2e214fe9c9b03cf67b181b22acf Cr-Commit-Position: refs/heads/master@{#31472}

Patch Set 1 #

Total comments: 2

Patch Set 2 : One test less. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M test/webkit/webkit.status View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Michael Starzinger
5 years, 2 months ago (2015-10-21 16:24:08 UTC) #1
Benedikt Meurer
LGTM modulo test failures. https://codereview.chromium.org/1410543007/diff/1/test/webkit/webkit.status File test/webkit/webkit.status (left): https://codereview.chromium.org/1410543007/diff/1/test/webkit/webkit.status#oldcode37 test/webkit/webkit.status:37: 'fast/js/deep-recursion-test': [PASS, NO_VARIANTS], Still seems ...
5 years, 2 months ago (2015-10-22 04:55:52 UTC) #2
Michael Starzinger
https://codereview.chromium.org/1410543007/diff/1/test/webkit/webkit.status File test/webkit/webkit.status (left): https://codereview.chromium.org/1410543007/diff/1/test/webkit/webkit.status#oldcode37 test/webkit/webkit.status:37: 'fast/js/deep-recursion-test': [PASS, NO_VARIANTS], On 2015/10/22 04:55:52, Benedikt Meurer wrote: ...
5 years, 2 months ago (2015-10-22 12:01:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410543007/2 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410543007/2
5 years, 2 months ago (2015-10-22 12:09:28 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:2)
5 years, 2 months ago (2015-10-22 12:26:18 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-10-22 12:26:37 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/bfdfb4884810a2e214fe9c9b03cf67b181b22acf
Cr-Commit-Position: refs/heads/master@{#31472}

Powered by Google App Engine
This is Rietveld 408576698