Always dispose backing store.

Always dispose backing store.

(With a v8::Vector, the client is responsible for memory management.
 I think there can be a situation where the Vector has a char[1] backing
 store with '\0' in it, in which case the current code would leak.
 If we always Dispose() the backing store this should be avoided.
 Since dispose will delete[] the actual backing store, this should
 also work then the backing store is nullptr.)

R=jochen@chromium.org
BUG=chromium:525885
LOG=N

Committed: https://crrev.com/7770e021297ac7ad902b8271be049f45b9090e7c
Cr-Commit-Position: refs/heads/master@{#31446}

[vogelheim, 2015-10-21 13:51:33]

Bug fixing by deleting code. \o/

[jochen (gone - plz use gerrit), 2015-10-21 13:53:16]

lgtm

[vogelheim, 2015-10-21 15:25:54]

The CQ bit was checked by vogelheim@chromium.org

[commit-bot: I haz the power, 2015-10-21 15:26:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1410543005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1410543005/1

[commit-bot: I haz the power, 2015-10-21 15:28:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-21 15:28:04]

Try jobs failed on following builders:
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/6901)

[vogelheim, 2015-10-21 15:28:45]

Description was changed from

==========
Always dispose backing store.

(With a v8::Vector, the client is responsible for memory management.
 I think there can be a situation where the Vector has a char[1] backing
 store with '\0' in it, in which case the current code would leak.
 If we always Dispose() the backing store this should be avoided.
 Since dispose will delete[] the actual backing store, this should
 also work then the backing store is nullptr.)

R=jochen@chromium.org
BUG=chromium:525885
==========

to

==========
Always dispose backing store.

(With a v8::Vector, the client is responsible for memory management.
 I think there can be a situation where the Vector has a char[1] backing
 store with '\0' in it, in which case the current code would leak.
 If we always Dispose() the backing store this should be avoided.
 Since dispose will delete[] the actual backing store, this should
 also work then the backing store is nullptr.)


R=jochen@chromium.org
BUG=chromium:525885
LOG=N
==========

[vogelheim, 2015-10-21 15:28:49]

The CQ bit was checked by vogelheim@chromium.org

[commit-bot: I haz the power, 2015-10-21 15:29:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1410543005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1410543005/1

[commit-bot: I haz the power, 2015-10-21 15:30:07]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-10-21 15:30:32]

Patchset 1 (id:??) landed as
https://crrev.com/7770e021297ac7ad902b8271be049f45b9090e7c
Cr-Commit-Position: refs/heads/master@{#31446}